fix: tolerate missing 'page' key in process_none_page_numbers - #425
Open
Yi-111-a wants to merge 1 commit into
Open
fix: tolerate missing 'page' key in process_none_page_numbers#425Yi-111-a wants to merge 1 commit into
Yi-111-a wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69, closes #97
Problem
process_none_page_numbers in \pageindex/page_index_classic.py\ assumed every TOC item carries a \page\ key and used hard \del:
\\python
item_copy = copy.deepcopy(item)
del item_copy['page'] # KeyError when the LLM-returned TOC entry has no 'page'
...
del item['page']
\\
TOC entries produced/cleaned upstream may lack \page\ entirely, so index builds crash with \KeyError: 'page'\ (reported in #69 and #97).
Fix
Replace both hard \del\s with \dict.pop(key, None). Behavior is unchanged for items that do have \page; items without it no longer crash.
Tests
Added two regression tests to \ ests/test_page_index.py:
Both fail on \main\ with exactly \KeyError: 'page'\ at page_index_classic.py:842 and pass with this change:
\
tests/test_page_index.py 5 passed
\\
Tested with Python 3.11 on Windows (\pytest tests/test_page_index.py -v). No other behavior touched.