Repository navigation
Conversation
Use the supplied top message ID when selecting the activity space for ordinary private-chat typing. Topic views subscribe to that thread space, so storing the update globally leaves them without typing activity. Match the existing channel typing route while preserving the voice-chat and no-thread branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private bot topics can miss ordinary typing indicators.
updateUserTypingreadstopMsgId, but stores non-draft activity in the global activity space. A topic's chat controller subscribes to.thread(threadId), so it does not receive that activity.Use the supplied thread ID for ordinary private-chat activity, matching the existing
updateChannelUserTypingbranch. Keep voice-chat activity in.voiceChatand unthreaded activity in.global. Draft and stop-draft handling is unchanged.Source review confirms that the two routes now select the same activity category and that the rest of the file is unchanged. The diff passes
git diff --check.Draft pending an iOS build and device or simulator verification. This Linux environment has no Swift toolchain, and the configured remote Mac is unavailable. Required UI checks: typing appears in the addressed bot topic, does not appear in another topic, clears on completion, and still appears in an ordinary private chat. This patch has not been verified in an installed iPhone app.