Repository navigation
Conversation
2 tasks done
kor-ka
changed the title
kor-ka
marked this pull request as ready for review
October 19, 2026 23:05
|
|
kor-ka
force-pushed
the
fix-webapp-fullscreen
branch
from
October 27, 2026 00:31
dda2805 to
7f750ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Fix #2383
A fullscreen Mini App's sheet doesn't fully cover screen, so the system compositor keeps drawing chat under it every frame page changes.
Two things prevent it from covering chat completely:
Changes:
1. Landscape scale
AttachmentContainer.updatesetsscaleProgressto 1 in landscape, so every sheet is scaled - chat shows strips at sides, top and bottom.Fix:
scaleProgressis 0 in landscape.2. Rounded corners
A fullscreen sheet keeps its rounded clip corners.
Fix: introduce
updateCornerRadius- make corners square while a fullscreen sheet is at top and nothing moves it, rounded when something does.Screenshots
Measurement
Tool: Instruments, Metal System Trace
Hardware: iPhone 14 Plus (A15), iOS 26.6.2, landscape
Content: 3D game webGPU/JS
Tested
iPhone 14 Plus, iOS 26.6.2,
portrait and landscape: a fullscreen Mini App covers the screen edge to edge
portrait: Mini App corners are rounded while it moves
fix_animation.MP4
Out of scope, but nice
Attachment menu gaps are also fixed in landscape as a side effect