fix(db): release synced keys after delete - #1787
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe synced delete path now removes deleted keys from ChangesSynced key deletion
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The fix removes deleted row keys from synchronized state while preserving surviving keys, with focused regression coverage and passing checks. No actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
CollectionStateManager.syncedKeysduring synced deletes.@tanstack/dbpatch changeset.The regression test inserts two rows and deletes one. Before this fix, the deleted row’s key remains in syncedKeys; after the fix, only the surviving row’s key remains.
Closes #1786
Testing
pnpm build— passedpnpm test— passed across all 28 workspace packages@tanstack/db— 3,324 tests passed, 6 skipped; no type errors✅ Checklist
pnpm test.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Tests
Release