Fixed missing permission in private calls in background#778
Merged
vkryl merged 3 commits intoTGX-Android:mainfrom Oct 30, 2024
Merged
Fixed missing permission in private calls in background#778vkryl merged 3 commits intoTGX-Android:mainfrom
vkryl merged 3 commits intoTGX-Android:mainfrom
Conversation
vkryl
requested changes
Oct 30, 2024
Member
|
As mentioned in the group, while technically it fixes the issue, microphone-related foreground service permissions most likely won't pass a GP review for the purpose of a phone call. But let's see if this is still the case. |
|
Main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several issues I’ve fixed here, including a serious bug where the notification gets deleted when the app opens, effectively “canceling” the permissions granted through it. I’ve also added some future permissions like Media Projection and Camera. Based on tests, the call can now stay in the background without the microphone cutting out.