fix: stale stats and incorrect token breakdown after Compaction - #564
Open
licat2023 wants to merge 1 commit into
Open
fix: stale stats and incorrect token breakdown after Compaction#564licat2023 wants to merge 1 commit into
licat2023 wants to merge 1 commit into
Conversation
Two related bugs when /Compaction runs: 1. analyzeTokens() did not filter compacted messages when searching for firstAssistant/lastAssistant, causing system prompt tokens to be calculated from stale pre-compaction messages. This broke the token breakdown percentages in /dcp context. 2. resetOnCompaction() did not reset state.stats, systemPromptTokens, or compressionTiming, causing pruned-token counts and session statistics to show stale pre-compaction values. Root cause & analysis in #5xx (issue to follow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563
What this PR does
Fixes two related bugs where DCP statistics become stale after OpenCode's
/Compactionruns:Bug 1:
analyzeTokensignores compaction boundaryfirstAssistant/lastAssistantsearch loops now filter compacted messages viaisMessageCompacted()breakdown.systemand corrupting all category percentagesBug 2:
resetOnCompactionmisses state resetstate.stats,state.systemPromptTokens, andstate.compressionTimingChanges
lib/commands/context.ts!isMessageCompacted(state, msg)tofirstAssistantandlastAssistantsearchlib/state/utils.tsstats,systemPromptTokens,compressionTiminginresetOnCompactionVerification
tsc --noEmit)npm run build)/Compaction?/dcp contextnow shows correct post-compaction stats