[pull] master from tensorflow:master - #1390
Merged
Merged
Conversation
The shuffle() and zip() docstrings do not mention that zipping a shuffled dataset with an unshuffled one breaks element correspondence. Users hit this and think zip is re-triggering the shuffle. Added a section to shuffle() explaining the issue with a code example showing the two correct approaches (shuffle after zip, or same seed). Added a note to zip() pointing users to the shuffle docs. Fixes #70521
Automated security fix generated by OrbisAI Security
Adds GetOrRegisterDatasetInvalidDatasetId to grpc_dispatcher_impl_test.cc to verify that backslash, slash, '.', and '..' dataset IDs are rejected via the public gRPC API rather than calling the internal ValidateDatasetId function directly.
Imported from GitHub PR openxla/xla#47502 📝 Summary of Changes Tag FileCheck only gpu tests with gpu tag only 🎯 Justification This allows them to be run on rocm_cpu step of CI 🚀 Kind of Contribution 🧪 Tests 📊 Benchmark (for Performance Improvements) N\A 🧪 Unit Tests: None 🧪 Execution Tests: None Copybara import of the project: -- 1d1f8ebd6c98d540aedb33625d4e1f0f8af756c2 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>: [ROCm] Separate lit test that use FileCheck only This allows them to be run on rocm_cpu step of CI Merging this change closes #47502 PiperOrigin-RevId: 973827849
PiperOrigin-RevId: 973835112
Part of a stacked effort towards adding tooling to measure and generate GPU bandwidth derate tables reproducibly. This CL introduces `GetPeakBandwidthBytesPerSec(int device_id)`, which dynamically queries the active `StreamExecutor` to retrieve the theoretical peak GPU memory bandwidth at runtime. Test: Added unit tests. PiperOrigin-RevId: 973840679
Without sorting, they are dumped in arbitrary order, which makes dumps not bit-identical, which makes it harder to hunt for indeterminism. I've checked a model that produced non-deterministic dumps before, this change fixes it. PiperOrigin-RevId: 973891310
PiperOrigin-RevId: 973902250
…to patch. This aligns rules_proto version across Bzlmod and WORKSPACE builds. PiperOrigin-RevId: 973931168
…-side telemetry PiperOrigin-RevId: 973939699
PiperOrigin-RevId: 973939820
PiperOrigin-RevId: 973941174
Storing weights outside of flatbuffer should also respect alignment requirement. For now this is just matching alignment requirement for tensors stored inside flatbuffer with constants stored outside PiperOrigin-RevId: 973945746
…mode PiperOrigin-RevId: 973960856
…aset-id-backslash-path-traversal PiperOrigin-RevId: 973983980
PiperOrigin-RevId: 973984402
PiperOrigin-RevId: 973997845
…nPjRtClient instead. PiperOrigin-RevId: 974000504
Currently, this is not supported by the autotuner and we get the following error: RET_CHECK failure (xla/backends/gpu/runtime/collective_thunk.cc:378) params.collective_params && params.collective_params->device_assn Collective parameters and device assignment are required for collective thunk execution PiperOrigin-RevId: 974002561
PiperOrigin-RevId: 974002876
…_tpu migration layout PiperOrigin-RevId: 974005318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )