Add interactions and behaviours for Al-Kharid npcs and flyer item - #1247
Open
V0lcanic wants to merge 3 commits into
Open
Add interactions and behaviours for Al-Kharid npcs and flyer item#1247V0lcanic wants to merge 3 commits into
V0lcanic wants to merge 3 commits into
Conversation
… in Al-Kharid from the todo list of GregHib#1222. Other Daemonheim adjustments that were missed have also been added, fully restoring the area to how it was in 2011. Changed: al_kharid.npc-spawns.toml -Fixed a few incorrect/broken spawns. Source: osrs live server, osrs.world 634 al_kharid.npcs.toml -Marked shop = "gem_trader" to [gem_trader] AliTheLeafletDropper.kt -Adds the Al Kharid flyer-dropper NPC script: it starts an overhead chat timer on spawn, cycles random market-style barks, and gives the NPC a talk-to dialogue that changes after The Feud. It also adds flyer handout logic with duplicate/full-inventory checks plus the item-on-NPC rejection line for outdated flyers. Source: osrs live server, rs3 live server AlKharidFlyer.kt -Adds a readable flyer item interaction for al_kharid_flyer, showing Ali Morrisane’s market promo text and then flagging the voucher as out of date. AlKharidWarrior.kt -Adds Al Kharid warrior assist behaviour: when one warrior is attacked, nearby living warriors can flag themselves as helpers, shout a line, and auto-attack the same player. It also resets the help/assistance state on spawn and death so the chain stays clean between fights. GemTrader.kt -Adds the Al Kharid gem trader interaction: talking to the NPC now offers a simple buy-gems prompt that opens the gem_trader shop, and the separate trade option also opens the shop directly. Unrelated changes: EstrithDaemonheim.kt -Puts Estrith on her Daemonheim patrol, then listens for movement and only schedules dialogue when she lands on one of the patrol tiles. On those valid tiles, she has a random chance to speak after a short delay, with special lines reserved for the marked coordinates. Source: https://www.youtube.com/watch?v=MgbqYFJuHCQ, https://www.youtube.com/watch?v=xVoxwy6y3ZM, https://www.youtube.com/watch?v=OKUyt4sBEhY, https://www.youtube.com/watch?v=dwdswoak1dU (and the other 4 parts), https://runescape.wiki/w/Estrith daemonheim.npc-spawns.toml -Adds 1 missing "listless_dead_2" spawn. Source: osrs.world 634, https://www.youtube.com/watch?v=TwIcZL9IM9s 3:53. daemonheim.npcs.toml -Marked interacts = false for [fremennik_shipmaster_daemonheim] and [sonje]. Source: https://www.youtube.com/watch?v=TbFDLs-aOac 1:38. daemonheim.objs.toml -Adds object [tent_daemonheim] and examine text. daemonheim.patrols.toml -Adds Estrith’s patrol loop with 10-tick pauses on each tile and a backtracking route from the final point back to the start. falador.item-spawns.toml -Adds a missing 2x bronze arrow spawn. Source: osrs live server, rs3 live server.
…ped the stair variants to their correct floor-to-floor destinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the remaining interactions and behaviours of npcs and items in Al-Kharid from the todo list of #1222. Other adjustments that were missed for Daemonheim have also been added, fully restoring the area to how it was in 2011.
Changed:
al_kharid.npc-spawns.toml
-Fixed a few incorrect/broken spawns. Source: osrs live server, osrs.world 634.
al_kharid.npcs.toml
-Marked shop = "gem_trader" to [gem_trader].
AliTheLeafletDropper.kt
-Adds the Al Kharid flyer-dropper NPC script: it starts an overhead chat timer on spawn, cycles random market-style barks, and gives the NPC a talk-to dialogue that changes after The Feud. It also adds flyer handout logic with duplicate/full-inventory checks plus the item-on-NPC rejection line for outdated flyers. Source: osrs live server, rs3 live server.
AlKharidFlyer.kt
-Adds a readable flyer item interaction for al_kharid_flyer, showing Ali Morrisane’s market promo text and then flagging the voucher as out of date.
AlKharidWarrior.kt
-Adds Al Kharid warrior assist behaviour: when one warrior is attacked, nearby living warriors can flag themselves as helpers, shout a line, and auto-attack the same player. It also resets the help/assistance state on spawn and death so the chain stays clean between fights.
GemTrader.kt
-Adds the Al Kharid gem trader interaction: talking to the NPC now offers a simple buy-gems prompt that opens the gem_trader shop, and the separate trade option also opens the shop directly.
Unrelated changes:
EstrithDaemonheim.kt
-Puts Estrith on her Daemonheim patrol, then listens for movement and only schedules dialogue when she lands on one of the patrol tiles. On those valid tiles, she has a random chance to speak after a short delay, with special lines reserved for the marked coordinates. Source: https://www.youtube.com/watch?v=MgbqYFJuHCQ, https://www.youtube.com/watch?v=xVoxwy6y3ZM, https://www.youtube.com/watch?v=OKUyt4sBEhY, https://www.youtube.com/watch?v=dwdswoak1dU (and the other 4 parts), https://runescape.wiki/w/Estrith.
daemonheim.npc-spawns.toml
-Adds 1 missing "listless_dead_2" spawn. Source: osrs.world 634, https://www.youtube.com/watch?v=TwIcZL9IM9s 3:53.
daemonheim.npcs.toml
-Marked interacts = false for [fremennik_shipmaster_daemonheim] and [sonje]. Source: https://www.youtube.com/watch?v=TbFDLs-aOac 1:38.
daemonheim.objs.toml
-Adds object [tent_daemonheim] and examine text.
daemonheim.patrols.toml
-Adds Estrith’s patrol loop with 20-tick pauses on each tile and a backtracking route from the final point back to the start.
falador.item-spawns.toml
-Adds a missing 2x bronze arrow spawn. Source: osrs live server, rs3 live server.