Skip to content

Add Rum Deal quest - #1236

Open
Ebp90 wants to merge 1 commit into
mainfrom
rum-deal
Open

Add Rum Deal quest#1236
Ebp90 wants to merge 1 commit into
mainfrom
rum-deal

Conversation

@Ebp90

@Ebp90 Ebp90 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Quest implemented... required fixes to farming and a new follow mode added for Zombie protestors.
@Ebp90 @claude
Add Rum Deal quest
a84df07 
Braindeath Island content and the full quest script: Captain Braindeath,
Captain Donnie, Luke, Davey, the brewers, zombie swabs and protesters,
fever spiders and the Evil Spirit, plus Pirate Pete starting the quest in
Port Phasmatys.

Supporting changes:
- Blindweed farming patch - varbit, produce entry, patch registration and
  its objs config. Patches with no Rake option can now be raked by using a
  rake on them, a crop planted into an already clear patch starts the
  growth timer, and fully overgrown weeds stop at stage 3 instead of
  wrapping back to clear.
- Leash movement mode - follows a target only while both stay within range
  of the npc's spawn tile and loses interest otherwise. Follow teleports an
  npc that falls behind or changes level, which let protesters trail a
  player across the world.
- zombie_swab hunt mode so swab aggression can be judged per player.
- questprep/questreset admin commands and the req_item_ids quest param they
  read.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K22iXYZjnQnTr3ZUtbuGBG
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

9 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 6
Unused import directive 🔶 Warning 1
Duplicated code fragment ◽️ Notice 1
'when' that can be simplified by introducing an argument ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com
@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.22197% with 1227 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.56%. Comparing base (8905f58) to head (a84df07).

Files with missing lines Patch % Lines
...a/morytania/braindeath_island/CaptainBraindeath.kt 22.40% 383 Missing and 5 partials ⚠️
...in/kotlin/content/quest/member/rum_deal/RumDeal.kt 33.80% 304 Missing and 27 partials ⚠️
.../content/area/morytania/braindeath_island/Davey.kt 2.36% 124 Missing ⚠️
...content/area/morytania/braindeath_island/Brewer.kt 7.93% 114 Missing and 2 partials ⚠️
.../area/morytania/braindeath_island/CaptainDonnie.kt 2.46% 79 Missing ⚠️
...ent/area/morytania/braindeath_island/ZombieSwab.kt 23.07% 46 Missing and 4 partials ⚠️
...gregs/voidps/engine/entity/character/mode/Leash.kt 0.00% 40 Missing ⚠️
...ontent/area/morytania/port_phasmatys/PiratePete.kt 75.64% 34 Missing and 4 partials ⚠️
...n/content/area/morytania/braindeath_island/Luke.kt 78.57% 17 Missing and 1 partial ⚠️
...rea/morytania/braindeath_island/ZombieProtester.kt 10.52% 15 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
Files with missing lines Coverage Δ
game/src/main/kotlin/content/quest/Quest.kt 56.92% <100.00%> (+0.67%) ⬆️
...ain/kotlin/content/skill/farming/FarmingPatches.kt 100.00% <100.00%> (ø)
...tlin/world/gregs/voidps/cache/definition/Params.kt 0.00% <0.00%> (ø)
...nt/area/morytania/braindeath_island/FeverSpider.kt 42.85% <0.00%> (ø)
.../kotlin/content/skill/farming/FarmingPatchPlant.kt 61.53% <25.00%> (+3.72%) ⬆️
...e/src/main/kotlin/content/skill/farming/Farming.kt 70.25% <60.00%> (+1.58%) ⬆️
.../kotlin/content/skill/farming/FarmingPatchTreat.kt 54.65% <53.84%> (-0.48%) ⬇️
...ame/src/main/kotlin/content/quest/QuestCommands.kt 80.00% <80.00%> (ø)
...rea/morytania/braindeath_island/ZombieProtester.kt 21.62% <10.52%> (+0.93%) ⬆️
...n/content/area/morytania/braindeath_island/Luke.kt 78.57% <78.57%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1236      +/-   ##
============================================
- Coverage     43.75%   43.56%   -0.19%     
- Complexity    10315    10392      +77     
============================================
  Files          2050     2057       +7     
  Lines         91696    93369    +1673     
  Branches      14955    15113     +158     
============================================
+ Hits          40123    40680     +557     
- Misses        45798    46865    +1067     
- Partials       5775     5824      +49
Components Coverage Δ
Content 43.78% <31.95%> (-0.24%) ⬇️
Engine 45.62% <0.00%> (-0.16%) ⬇️
Network 71.36% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Ebp90