Skip to content

Add The Hand in the Sand quest - #1219

Open
Ebp90 wants to merge 1 commit into
mainfrom
hand-in-the-sand
Open

Add The Hand in the Sand quest#1219
Ebp90 wants to merge 1 commit into
mainfrom
hand-in-the-sand

Conversation

@Ebp90

@Ebp90 Ebp90 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Ones issue: Betty should stop interacting with the player and walk to the nearest tile to the table to place the glass on it. Marked as TODO
@Ebp90 @claude
Add The Hand in the Sand quest
017e7db 
Covers the full quest: Bert's severed hand, the drunk Guard Captain,
Zavistic Rarve, Sandy's rota and interrogation, Betty's truth serum
chain, Mazion on Entrana, and the instanced sandpit refill cutscene.

Renames four item definitions to the ids the existing content already
referenced (beer_hand, magic_scroll, magical_orb_active, wizard_head),
names all seventeen quest stages in the varbit so progress is stored as
a string like every other quest, and moves the two server-only flags to
a vars.toml because varbits require an id.

Frincos registered his Talk-to against 'mazion' rather than 'frincos',
stacking a second handler on Mazion and opening a shop he doesn't own.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Ebp90

Ebp90 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Also Betty needs to sell pink dye after the quest.
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

5 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 4
Redundant 'suspend' modifier 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.32910% with 446 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.70%. Comparing base (e7baaaf) to head (017e7db).

Files with missing lines Patch % Lines
...ent/quest/member/hand_in_the_sand/HandInTheSand.kt 34.66% 154 Missing and 10 partials ⚠️
...n/kotlin/content/area/asgarnia/port_sarim/Betty.kt 27.69% 83 Missing and 11 partials ⚠️
.../main/kotlin/content/area/kandarin/yanille/Bert.kt 46.62% 70 Missing and 9 partials ⚠️
...ain/kotlin/content/area/karamja/brimhaven/Sandy.kt 57.00% 34 Missing and 9 partials ⚠️
...ntent/area/kandarin/yanille/GuardCaptainYanille.kt 40.00% 25 Missing and 5 partials ⚠️
...ain/kotlin/content/area/asgarnia/entrana/Mazion.kt 32.50% 25 Missing and 2 partials ⚠️
...lin/content/area/kandarin/yanille/ZavisticRarve.kt 86.36% 4 Missing and 5 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...in/kotlin/content/area/asgarnia/entrana/Frincos.kt 33.33% <100.00%> (ø)
game/src/main/kotlin/content/quest/Quest.kt 56.92% <100.00%> (+0.67%) ⬆️
...lin/content/area/kandarin/yanille/ZavisticRarve.kt 44.81% <86.36%> (+19.69%) ⬆️
...ain/kotlin/content/area/asgarnia/entrana/Mazion.kt 37.20% <32.50%> (-5.65%) ⬇️
...ntent/area/kandarin/yanille/GuardCaptainYanille.kt 40.00% <40.00%> (ø)
...ain/kotlin/content/area/karamja/brimhaven/Sandy.kt 57.00% <57.00%> (ø)
.../main/kotlin/content/area/kandarin/yanille/Bert.kt 46.62% <46.62%> (ø)
...n/kotlin/content/area/asgarnia/port_sarim/Betty.kt 29.32% <27.69%> (-0.68%) ⬇️
...ent/quest/member/hand_in_the_sand/HandInTheSand.kt 34.66% <34.66%> (ø)

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1219      +/-   ##
============================================
+ Coverage     43.65%   43.70%   +0.05%     
- Complexity    10262    10305      +43     
============================================
  Files          2041     2045       +4     
  Lines         91429    92192     +763     
  Branches      14923    15030     +107     
============================================
+ Hits          39913    40297     +384     
- Misses        45756    46081     +325     
- Partials       5760     5814      +54
Components Coverage Δ
Content 43.94% <43.32%> (+0.07%) ⬆️
Engine 45.81% <ø> (ø)
Network 71.40% <ø> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Ebp90