fix(eval): route Modal runs to the requested export - #244
Open
rylinjames wants to merge 1 commit into
Open
Conversation
The Modal LIBERO wrapper accepted export_dir but never passed it to the wrapped script, so tether eval --runtime modal could evaluate the default smolvla_libero_monolithic reference export while reporting results for a user's path. Map the requested export directory to the Modal ONNX volume subdir and pass --onnx-subdir on every suite invocation. Local paths map by basename; /onnx_out paths preserve their relative subdir. If the volume subdir is missing, Modal now fails loudly instead of silently using the baked-in reference export. Tests: PYTHONPATH=src /Users/romirjain/Desktop/building\ projects/fastcrest/tether/.venv/bin/python -m pytest tests/test_eval_modal_runner.py tests/test_eval_cli.py -p no:cacheprovider Lint: PYTHONPATH=src /Users/romirjain/Desktop/building\ projects/fastcrest/tether/.venv/bin/ruff check src/tether/eval/modal_runner.py tests/test_eval_modal_runner.py Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tether eval --runtime modal <export_dir>to a concrete/onnx_out/<subdir>Modal volume export instead of falling back to the script default--onnx-subdiron every Modal suite invocationValidation
PYTHONPATH=src /Users/romirjain/Desktop/building\ projects/fastcrest/tether/.venv/bin/python -m pytest tests/test_eval_modal_runner.py tests/test_eval_cli.py -p no:cacheproviderPYTHONPATH=src /Users/romirjain/Desktop/building\ projects/fastcrest/tether/.venv/bin/ruff check src/tether/eval/modal_runner.py tests/test_eval_modal_runner.py🤖 Generated with Claude Code