fix: skip performMaintenance() in dry-run mode - #68
Merged
Conversation
performMaintenance() archives session logs and deletes evolver hand sessions regardless of the --dry-run flag. This causes unexpected side effects (moving 1000+ session files) when users expect a read-only dry run. Guard the call with IS_DRY_RUN check so dry-run mode produces no file system mutations.
fmw666
pushed a commit
that referenced
this pull request
Mar 2, 2026
Add LKCY33 (PR #21), hendrixAIDev (PR #68), toller892 (PR #149). Update onthebigtree, voidborne-d, blackdogcat entries with full contributions. Co-authored-by: LKCY33 <lkcY33@users.noreply.github.com> Co-authored-by: Hendrix <hendrix.ai.dev@gmail.com> Co-authored-by: toller892 <1094086026@qq.com> Co-authored-by: Yewlne <dev@yewlne.com>
fmw666
pushed a commit
that referenced
this pull request
Mar 11, 2026
- PR #68 (hendrixAIDev): guard performMaintenance with IS_DRY_RUN - PR #26 (onthebigtree): hash hostname in env fingerprint, portable validation paths - PR #63 (voidborne-d): add 61 unit tests for core GEP modules - PR #21 (LKCY33): add dotenv path rewrite for public build - PR #25 (onthebigtree): already applied (currentSleepMs, matchPatternToSignals, max_files) - Update public.manifest.json: include test/*.test.js, add index.js dotenv rewrite Co-authored-by: Cursor <cursoragent@cursor.com>
fmw666
pushed a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
performMaintenance()runs unconditionally duringnode index.js run --dry-run, causing:Users expect
--dry-runto be read-only with zero file system side effects.Fix
Guard the
performMaintenance()call withIS_DRY_RUNcheck. When--dry-runis active, maintenance is skipped and a log message is printed instead.Testing
Before fix:
After fix:
Minimal change: 1 file, 6 insertions, 1 deletion.
Note
Low Risk
Small, localized control-flow change that only affects
--dry-runbehavior and reduces filesystem side effects.Overview
--dry-runevolver runs are now read-only with respect to session log maintenance.src/evolve.jsguards theperformMaintenance()call behind!IS_DRY_RUNand prints a skip message when dry-run is enabled, avoiding file deletes/moves (including archiving andevolver_hand_cleanup).Written by Cursor Bugbot for commit 51a5425. This will update automatically on new commits. Configure here.