Repository navigation
Announce the emoji button and contacts sort state to screen readers - #2163
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
The button beside the field of a chat opens the panel of emoji, stickers and GIFs, and while the panel is open it turns into a keyboard, and a press on it brings the keyboard back. Only the icon changed: the button was called the emoji button either way, so a reader could not tell that it would now close the panel. The button at the top of the contacts switches them between sorted by name and sorted by last seen, and shows which by its icon alone; it was called Change sorting, without a word of how they were sorted. The emoji button is called Keyboard while it brings the keyboard back, and the sorting button says how the contacts are sorted now.
mehranlatifi83
changed the title
mehranlatifi83
force-pushed
the
fix/talkback-button-state-from-icon-unsaid
branch
from
October 13, 2026 11:47
516e148 to
caa1421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix
ChatActivityEnterViewAnimatedIconView: label the button "Keyboard" while it shows the keyboard icon.ContactsActivity: include the current sort order in the label and announce it after a change.Testing
With TalkBack on, open the emoji panel in a chat and focus the button next to the input; then press sort in Contacts.
Before: "Emoji" and "Change sorting". After: "Keyboard", and the sort order is read.