Repository navigation
Fix business hours being read twice by screen readers - #2142
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
The opening hours on the profile of a business can be shown in its own time or in the reader's, and for today it says either the hours or how long until it opens. Every one of these is a text of its own laid over the others, and the ones not shown are only made see-through. A screen reader reads what is there, not what can be seen, so it read all of them: today's hours in both times and how long until opening, one after the other, and once the week was opened every day twice. Only the texts that are shown are read now, and the hours say whether the week under them is opened or closed.
mehranlatifi83
changed the title
mehranlatifi83
force-pushed
the
fix/talkback-business-hours-read-twice
branch
from
October 13, 2026 11:45
90d50ec to
656baa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Business hours on a profile (
ProfileHoursCell) can be shown in the business's time zone or the user's, and today's row shows either the hours or the time until opening. All versions are separate text views on top of each other, and the hidden ones only have alpha 0. TalkBack reads all of them, so today's hours are read two or three times, and each day of the week twice when expanded.Fix
Hide the invisible text views from accessibility, so only what is shown is read. The row also reports whether the week is expanded or collapsed.
Testing
With TalkBack on, open a business profile with opening hours and expand the week.
Before: hours were read several times. After: each is read once, and the row says expanded or collapsed.