Repository navigation
Fix screen readers leaving the mentions panel - #2126
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
The panel that opens over the field with the people of a group, when a name is being mentioned or a search is being narrowed to one member, is a list laid out much taller than the panel itself. It is moved so that only the part inside the panel shows, and the rest is behind the chat or under the bar at the bottom. Drawing stops at the edge of the panel, and a screen reader did not: the rows outside it were as much on the screen to it as the ones inside. Swiping went on past the last member that can be seen, onto members nobody can see, and the focus seemed to jump off somewhere in the chat, going forward and going back alike. Only what is inside the panel is offered to a screen reader now, and a finger exploring the part of the list that is not drawn goes through to what is under it, as a touch there already does. When a screen reader has the list scrolled, what is in sight is the panel, so a page of it is no taller than the panel and no member is carried past before it can be reached.
mehranlatifi83
force-pushed
the
fix/talkback-mentions-hidden-rows
branch
from
October 1, 2026 23:01
409792e to
14a42ba
Compare
mehranlatifi83
force-pushed
the
fix/talkback-mentions-hidden-rows
branch
from
October 13, 2026 11:44
14a42ba to
c298534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mentions panel (shown when typing @ in a group) is a list laid out much taller than the visible panel and shifted so only part of it shows. Drawing is clipped to the panel, but accessibility was not: rows outside the panel were still reported. Swiping went past the last visible member onto invisible ones, and focus seemed to jump into the chat.
Fix
In
MentionsContainerView:Testing
With TalkBack on, type @ in a large group and swipe through the panel forward and back.
Before: focus went past the visible members into the chat. After: it stays in the panel and scrolling skips no one.