Repository navigation
Make the star reaction sheet accessible to screen readers - #2106
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-star-reaction-sheet-unreachable
branch
from
September 18, 2026 09:50
683d26b to
aecb2b7
Compare
Holding the star on a message opens a sheet for sending stars with it, and three things in it were closed to a screen reader. The slider that chooses how many stars to send is a picture that answers to dragging, and dragging is the one thing touch exploration cannot do: it was reached as nothing at all, said nothing, and could not be moved. It is a slider in the reader's own words now, moved a twentieth of the way at a time, saying how many stars each move lands on. The row with the tick, that decides whether the name goes on the list of who sent stars, read its words and never its state: a press said nothing of which way it had just gone. It is a check box now, and says whether it is ticked. The people who sent the most stars are drawn as a row of pictures with a name and a number under each, by hand and in no view of their own, so a reader passed the whole thing without a word. It reads as the list it is: the heading, then each of them with what they sent, and whoever chose not to be named is read as anonymous, as the drawing shows them.
mehranlatifi83
force-pushed
the
fix/talkback-star-reaction-sheet-unreachable
branch
2 times, most recently
from
October 1, 2026 23:01
a6357c0 to
1b63451
Compare
mehranlatifi83
force-pushed
the
fix/talkback-star-reaction-sheet-unreachable
branch
from
October 13, 2026 11:43
1b63451 to
a1fce86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three parts of the star reaction sheet (
StarsReactionsSheet, opened by long pressing the star reaction) do not work with TalkBack:Fix
Testing
With TalkBack on, long press the star reaction on a channel post.
Before: the star count could not be changed and the senders were not read. After: the slider works with swipes, the checkbox says its state, and the senders are read.