Repository navigation
Announce the selected camera in the story camera - #2078
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-story-camera-switch-unsaid
branch
from
September 18, 2026 09:50
3876ae1 to
91d74bc
Compare
Turning the camera around gives a sighted eye the whole picture flipping, which is answer enough. A screen reader was given nothing: the button is named the same before and after, so there is no telling which camera you ended up on except by guessing, and nothing at all is said when it turns. Put the camera the button is looking through into its name, so it can be had by stopping on the button without pressing it, and say the new one when it changes, which is the moment the picture flips for everybody else. Every way of turning the camera around — the button, the double tap, the one in the bar — passes through the same place where the choice is remembered, so that is where it is picked up.
mehranlatifi83
force-pushed
the
fix/talkback-story-camera-switch-unsaid
branch
2 times, most recently
from
October 1, 2026 23:01
06dbf81 to
2b3651e
Compare
mehranlatifi83
force-pushed
the
fix/talkback-story-camera-switch-unsaid
branch
from
October 13, 2026 11:41
2b3651e to
cc94fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The switch camera button in the story camera has the same label for both cameras, and nothing is announced when the camera switches. A TalkBack user cannot tell which camera is active.
Fix
In
RecordControlandStoryRecorder, include the active camera (front or back) in the button label, and announce the new camera when it switches. All ways of switching (the button, double tap, and the toolbar button) go through the same place, so all are covered.Testing
With TalkBack on, open the story camera and swipe onto the switch camera button, then press it.
Before: same label for both cameras and no announcement. After: the label says the current camera and the new one is announced.