Repository navigation
Add a screen reader label to the poll attach button - #2071
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-attach-button-without-label
branch
from
September 18, 2026 09:50
9eab93e to
131b5a4
Compare
Beside the description of a poll, beside its explanation and beside every option there is a button for attaching a picture, a sticker, a place, a piece of music, a link or a file. It is a bare view drawn by hand with no text and no description, so a screen reader stops on it and says only that there is a button, without saying what it does. Once something is attached the icon is replaced by a thumbnail of it, and a press then goes to changing it rather than to adding. None of that was said either: nothing told you an option already carried a picture, or which one. Name the button after what a press on it does, and where something is already attached, say what it is. Every kind of attachment names itself, by its kind, or by the file name or the address where that says more. All of the words are ones the app already has. The button of the field that adds an option to a poll already sent is the same view, so it is named too, along with the emoji button beside it, which had no name either.
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-attach-button-without-label
branch
2 times, most recently
from
October 1, 2026 23:01
8fc03bb to
338ac92
Compare
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-attach-button-without-label
branch
from
October 13, 2026 11:40
338ac92 to
e882541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In poll creation, the attach button next to the description, the explanation and each option (to attach a photo, sticker, location, music, link or file) has no text or description. TalkBack reads only "button". When media is attached, the icon becomes a thumbnail and pressing it changes the media; this is not read either.
Fix
In
PollAttachButtonand thePollAttachedMedia*classes:All labels use existing app strings. The same button in the "add option" field of a sent poll (
PollAddOptionFieldLayout) is labelled too, along with the emoji button next to it.Testing
With TalkBack on, create a poll and swipe onto the attach button next to an option, then attach a photo and swipe onto it again.
Before: just "button". After: it says what it does, and once a photo is attached, it says so.