Repository navigation
Announce locked poll settings to screen readers - #2056
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-locked-switches-silent
branch
from
September 18, 2026 09:50
459e59a to
7e50578
Compare
Two of the settings are fixed at times: a poll may not take suggested options while it is a quiz or while it shows who voted, and a poll opened as a quiz stays one. Neither is disabled; each is marked with a small padlock drawn on its switch, and a press on it quietly does nothing. A screen reader is told none of that. It offers a switch, says whether it is on, and turning it does nothing, over and over, with no reason given. Say the setting is disabled, and say what would have to change first.
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-locked-switches-silent
branch
2 times, most recently
from
October 1, 2026 23:01
64cdad5 to
0f84aa6
Compare
mehranlatifi83
force-pushed
the
fix/talkback-poll-create-locked-switches-silent
branch
from
October 13, 2026 11:39
0f84aa6 to
af143ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some poll settings are locked in certain cases: "Allow adding options" cannot be turned on for a quiz or a poll with visible votes, and a quiz opened as a quiz stays a quiz. These switches are not disabled; they only show a small lock icon, and pressing them does nothing. TalkBack reads them as normal switches, and toggling them silently fails.
Fix
In
PollCreateCheckCell, when a setting is locked, report it as disabled and add the reason (what has to change first) to its description. Nothing changes visually.Testing
With TalkBack on, create a poll, turn on Quiz, then swipe onto "Allow adding options".
Before: a normal switch that did nothing when toggled. After: it is read as disabled, with the reason.