Repository navigation
Make the sender avatar menu accessible to screen readers - #2045
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-sender-avatar-menu
branch
2 times, most recently
from
September 2, 2026 14:11
f35c359 to
1015fa3
Compare
mehranlatifi83
force-pushed
the
fix/talkback-sender-avatar-menu
branch
from
September 18, 2026 09:50
1015fa3 to
9acf521
Compare
mehranlatifi83
force-pushed
the
fix/talkback-sender-avatar-menu
branch
from
September 27, 2026 10:45
9acf521 to
a09eeb3
Compare
The avatar of whoever sent a message opens a menu when it is held down: their profile, a chat with them, a mention of them, and a search of what they have said here. The avatar is drawn by the cell and is no view of its own, so touch exploration had nothing to hold and none of it could be reached. Offer the same menu as an action on the message, held down the way it is asked to be, so whatever the menu comes to hold is come by the same way it is by everyone else. Whether holding the avatar leads anywhere is for the chat to answer: it opens in a group and in a chat with yourself, and nowhere else. A sender with no picture still has the menu, only without the picture drawn above it, so the action follows that rather than the picture.
mehranlatifi83
force-pushed
the
fix/talkback-sender-avatar-menu
branch
2 times, most recently
from
October 1, 2026 23:01
a5d94af to
db7a13b
Compare
mehranlatifi83
force-pushed
the
fix/talkback-sender-avatar-menu
branch
from
October 13, 2026 11:38
db7a13b to
be405fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long pressing a sender's avatar in a group opens a menu: open profile, send message, mention, search their messages. The avatar is drawn by the cell and is not a view, so TalkBack cannot reach this menu at all.
Fix
In
ChatMessageCellandChatActivity, add an accessibility action on the message that opens this menu through the same code path as the long press on the avatar. It is only offered when the sender has a profile photo, because the menu is anchored to the photo and does not open without one.Long pressing the message itself still selects it, as before.
Testing
With TalkBack on, in a group, swipe onto a message from someone with a profile photo and open the actions.
Before: the avatar menu could not be reached. After: an action opens it with the same four options.