Repository navigation
Fix opening the replied message in topics with screen readers - #2044
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-reply-not-openable-in-topics
branch
from
August 30, 2026 09:45
423e69b to
922e3cc
Compare
mehranlatifi83
force-pushed
the
fix/talkback-reply-not-openable-in-topics
branch
from
September 18, 2026 09:50
922e3cc to
dfbe349
Compare
Touching what is drawn over a message goes to the message it answers. Doing the same with a screen reader did nothing at all, on every message in a topic and in the comments under a channel post, and on some messages elsewhere. Three conditions stood between the two. A thread was refused outright unless the message carried the id of the one the thread was started from, which a topic and a comment thread do not always have; a reply to a story was left out; and where the message was a forward, the same place holds where it came from rather than a reply, and touching it goes there, which was not done. The touch is one place and this was another, and they had drifted. What happens now is what happens on a touch, asked for in the same order. What is drawn there is also named for what it is: a forward said it was a reply, whatever it went on to open.
mehranlatifi83
force-pushed
the
fix/talkback-reply-not-openable-in-topics
branch
2 times, most recently
from
October 1, 2026 23:01
dbac21a to
d835640
Compare
mehranlatifi83
force-pushed
the
fix/talkback-reply-not-openable-in-topics
branch
from
October 13, 2026 11:38
d835640 to
856350a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tapping the reply preview above a message jumps to the original message. With TalkBack, activating it does nothing in forum topics, in channel comments, and on some other messages.
The accessibility handler used different checks from the touch handler:
Fix
In
ChatMessageCell, make the accessibility action do exactly what the touch handler does, with the same checks in the same order. Also name the area correctly: a forward source is no longer called a reply.Testing
With TalkBack on, in a forum topic or channel comments, swipe onto the reply preview of a message and double tap.
Before: nothing happened. After: it jumps to the replied message, as tapping does. Story replies and forward sources work the same way.