Repository navigation
Fix the attach button being unreachable by touch exploration - #2002
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
3 times, most recently
from
August 3, 2026 17:15
e2e7c71 to
d213821
Compare
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
2 times, most recently
from
August 29, 2026 19:07
05bc60f to
a42d018
Compare
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
from
September 18, 2026 09:50
a42d018 to
3d7427d
Compare
The container of the send button is wider than the button shown in it and reaches over the attach button next to it. Exploring by touch where the attach button is drawn therefore lands on the send button, and a long press there opens the send options, since a long press on the container is what a screen reader is given to reach them. Moving by swipe finds the attach button correctly, which is why only exploring by touch is affected. Let the container take touch and hover only where a button of its own is shown, so what is touched is what is drawn.
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
from
September 27, 2026 10:45
3d7427d to
715cff4
Compare
|
@Arseny271 , could you take a look when you have a moment? |
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
from
October 1, 2026 23:01
715cff4 to
982d581
Compare
1 of 10 tasks
mehranlatifi83
force-pushed
the
fix/talkback-attach-button-under-send-container
branch
from
October 13, 2026 11:37
982d581 to
91c32a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With nothing typed, exploring the message bar by touch where the attach button is drawn lands on the record voice message button, and a long press there opens the send options instead of the attach menu. Moving by swipe reaches the attach button correctly, so only exploring by touch is affected.
The container of the send button is 100dp wide and sits over the attach button next to it, while the button shown inside it is only as wide as itself. Touch and hover therefore stop at the container wherever the attach button is, and a long press on the container is what a screen reader is given to reach the send options.
Let the container take touch and hover only where a button of its own is shown, so what is touched is what is drawn. While recording it keeps taking everything over it, since its button is faded out and the recording circle takes its place there.
Checking it
With TalkBack on, in a chat with something typed in the box, drag a finger over the attach button next to the send button.
Before, the touch landed on the send button, since its container reaches over what is drawn beside it, and a long press there opened the send options. Now what is touched is what is drawn.
Swiping found the attach button correctly before this, which is why only exploring by touch was affected.