Notification when group name or photo is changed#196
Open
naptar wants to merge 1 commit intoDrKLO:masterfrom
Open
Notification when group name or photo is changed#196naptar wants to merge 1 commit intoDrKLO:masterfrom
naptar wants to merge 1 commit intoDrKLO:masterfrom
Conversation
Updated to make for more clear reading. Currently, this formats to: "Andy has edited the group's Hiking Club name" Which is a bit odd. This change proposes to make this: "Andy has edited the "Hiking Club" group's name"
|
Why not: "Andy changed the group name from "Hiking club" to "Hickup club" ? |
|
@mrvdb I think the previous name is not available for the language string. What about "Andy has edited the group name of Hiking Club" ? Seems more accurate to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to make for more clear reading. Currently, this formats to:
"Andy has edited the group's Hiking Club name"
Which is a bit odd.
This change proposes to make this:
"Andy has edited the "Hiking Club" group's name"