Conversation
Instead of always adding new emojis at the beginning of the recents list (and thus shuffling the list and confusing the user) add them to the end of that list first. The specified emoji only gets shifted to the beginning if it's already in the list. (Make sure to add them as the second last element, so that it is still added if we already have the max number of emojis in there) This way, the emoji layout in the recents table is more consistent and easier to remember for the user.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, selected emojis are always added to the beginning of the recents list. This shifts the whole layout, making it hard for the user to memorize it.
Selected emojis should be added at the end of that list instead. They are only moved to the beginning if the user selects them again via the regular emoji grid. Also, we make sure to add them in the second last slot, so they replace the last emoji if we already have the max number of emojis in there.
This makes the recents layout more consistent and easier to remember for the user.