fix(api): preserve media type for scoped book lookup - #114
Open
snapetech wants to merge 1 commit into
Open
Conversation
Pass the requested media type through the remote lookup path so scoped clients receive results of the type they requested before lookup filtering is applied.
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
Book lookup already accepts a
mediaTypequery parameter and filters remote results with it, but the remote text-search path was not given that value. Goodreads autocomplete results therefore kept the defaultAudiobookmedia type, so an ebook lookup filtered every result out.This passes the requested
BookMediaTypefromBookLookupControllerthroughISearchForNewBookandBookInfoProxy. Calls without a scope keep the existing behavior.I added regression coverage for both the controller forwarding the requested type and Goodreads text results retaining it.
Testing:
dotnet build src/Chaptarr.sln --configuration Release --no-restoredotnet test src/Chaptarr.Core.Test/Chaptarr.Core.Test.csproj --configuration Release --no-restore