Repository navigation
fix(web): delete Caps left behind by failed file imports - #3614
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a browser file import died partway (network drop etc) the cap row was already created, so it stayed in the library while the user got told to try again, and every retry made another one. videos showed upload failed forever and images were left with no media at all.
now if the upload fails before all the bytes are sent, or storage explicitly rejects it, the import deletes the cap it created (the web recorder already does the same), and the paste import refreshes so the deleted card doesn't hang around. if all the bytes went out and only the response got lost, an image is kept only when storage confirms it has the file, and a video keeps the existing processing check.
The changes since the previous review appear safe to merge.Summary
This PR deletes Caps created by failed file imports and refreshes the dashboard after a failed paste import.
No new actionable issues were found in the changes since the previous review. Tests were inspected but not run.
Reviews (4) · Last reviewed commit: "fix(web): report rejected image uploads ..." · Reviewed by Greptile