Repository navigation
fix(web): remove reply notifications when their parent comment is deleted - #3612
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deleting a top level comment never cleaned up the "x replied to your comment" notifications on it, so people kept seeing them and they kept counting toward the unread badge. the cleanup looked for the parent comment id nested under the comment in the notification data, but replies store it at the top level, so the query never matched anything. the mobile delete endpoint copied the same query.
now both look in the right place. one line each, checked against a real mysql row. notifications that already went stale aren't cleaned up.
stacked on #3325, which touches the same cleanup and whose test asserted the old path. the first commit here is #3325's, so review just the second.
The reviewed commit appears safe to merge.Summary
Corrects reply-notification cleanup in web and mobile comment deletion.
Acknowledged limitation: yashranaway explicitly states that notifications already left stale are not cleaned up.
Reviews (1) · Last reviewed commit: "fix(web): remove reply notifications whe..." · Reviewed by Greptile