Repository navigation
fix(chrome-extension): cancel the mic warning when its tab closes or navigates - #3607
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when you start a recording with no or a silent mic, the extension asks "record without a microphone?" in the tab. if you close, reload or navigate that tab instead of answering, nothing tells the service worker, so the start just hangs for the 2 minute prompt timeout, and every start click from the panel or floating bar joins that same stuck start and spins.
now while the prompt is up it also answers "cancel" when the page goes away, the same answer the cancel button sends, so the worker's normal cancel path frees things up right away. a crashed tab still falls back to the timeout.
The PR appears safe to merge.Summary
Adds cancellation when the microphone warning’s page closes, reloads, or navigates.
No actionable issues found. Tests were inspected but not run.
Reviews (1) · Last reviewed commit: "fix(chrome-extension): cancel the mic wa..." · Reviewed by Greptile