Adding default pyoutline home and user directories to the config #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipriano
reviewed
May 14, 2019
bcipriano
requested changes
May 14, 2019
pyoutline/outline/config.py
Outdated
| __all__ = ["config"] | ||
|
|
||
| PYOUTLINE_ROOT_DIR = os.path.dirname(os.path.dirname(__file__)) | ||
| DEFAULT_USER_DIR = '{}/opencue/outline/{}'.format(tempfile.gettempdir(), getpass.getuser()) |
There was a problem hiding this comment.
We should probably use os.path.join here too.
There was a problem hiding this comment.
In anticipation of python3, I'd like to move to using pathlib. I've added a new commit to reflect this. @bcipriano Let me know your thoughts.
added 2 commits
May 14, 2019 16:34
bcipriano
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #228
The
homeanduser_dirvariables of theoutline.cfgshould be specified by the user. If they are not this change provides some defaults.