Add a flag to search job with appended results #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new configuration option `search_jobs.append_results` in cuegui.yaml to control job search behavior. - If `search_jobs.append_results` is set to true, search results will be appended to the current list of monitored jobs. - If `search_jobs.append_results` is set to false, the existing jobs will be cleared before displaying the search results. - Updated Constants.py to include the new configuration parameter. - Modified MonitorJobsPlugin.py to conditionally clear the job monitor based on the config setting.
ramonfigueiredo
requested review from
bcipriano and
DiegoTavares
as code owners
DiegoTavares
approved these changes
Sep 19, 2024
cuegui/cuegui/config/cuegui.yaml
Outdated
Comment on lines
156
to
158
| # A flag for search job with appended results | ||
| # true to appended to the current list of monitored jobs, | ||
| # false to clear the current job list and show only the new search results |
There was a problem hiding this comment.
Suggested change
| # A flag for search job with appended results | |
| # true to appended to the current list of monitored jobs, | |
| # false to clear the current job list and show only the new search results | |
| # Define whether or not new jobs should be appended to the current list of jobs on the JobMonitor widget | |
| # - True: search result will append jobs to the current list of monitored jobs | |
| # - False: repopulate the jobs table with the search result |
Done, thanks! |
ramonfigueiredo
merged commit 388255c
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_jobs.append_resultsin cuegui.yaml to control job search behaviour.search_jobs.append_resultsis set to true, search results will be appended to the current list of monitored jobs.search_jobs.append_resultsis set to false, the existing jobs will be cleared before displaying the search results.