Skip to content

[cuegui] Enable some separator characters on service name #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[cuegui] Enable some separator characters on service name #1492

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8a1f22
Enable some separator characters on service name
DiegoTavares Mar 23, 2023
6f2b45d
Fix suggested issue
DiegoTavares Aug 21, 2024
0dc57ef
Merge branch 'master' into loose_service_name_req
DiegoTavares Aug 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cuegui/cuegui/ServiceDialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,18 @@ def save(self):
Create and emit a ServiceData object based
on the contents of the form.
"""
if len(str(self.name.text())) < 3:
service_name = str(self.name.text())
if len(service_name) < 3:
QtWidgets.QMessageBox.critical(self, "Error",
"The service name must be at least 3 characters.")
return

if not str(self.name.text()).isalnum():
# Allow alphanumeric chars and | / - _
# chars like , and . can be used as separators in other parts of the API and behave
# inconsistently
if (not service_name.isalnum()) and \
[char for char in service_name
if not char.isalnum() and char not in "|/-_"]:
QtWidgets.QMessageBox.critical(self, "Error", "The service name must alphanumeric.")
return

Expand All @@ -176,7 +182,7 @@ def save(self):
service = opencue.wrappers.service.Service()
if self.__service:
service.data.id = self.__service.data.id
service.setName(str(self.name.text()))
service.setName(service_name)
service.setThreadable(self.threadable.isChecked())
service.setMinCores(self.min_cores.value())
service.setMaxCores(self.max_cores.value())
Expand Down
Loading