Fix logdone by writing CLOSED timestamps on TODO completion - #1124
Open
chadhs wants to merge 2 commits into
Open
Fix logdone by writing CLOSED timestamps on TODO completion#1124chadhs wants to merge 2 commits into
chadhs wants to merge 2 commits into
Conversation
Honor #+STARTUP: logdone and :LOGGING: logdone so completing a TODO adds a CLOSED planning timestamp, matching Emacs org-log-done behavior.
chadhs
marked this pull request as ready for review
August 11, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#+STARTUP: logdone/:LOGGING: logdonewhen completing TODOs by writing aCLOSED:planning timestamp (and remove it when leaving a done state)org-log-done/timebehavior for non-repeating tasksREADME.orgVerification
Reproduced the reporter's exact fixture from #980:
After advancing TODO → DONE, export contains:
Unit tests cover STARTUP/property detection, CLOSED add/remove, SCHEDULED preservation, and the no-logdone default.
Test plan
yarn test --testPathPattern='(org\.unit\.test|OrgFile\.unit\.test)'CLOSED:is written on completion#+STARTUP: logdonenologdoneand missinglogdonedo not writeCLOSED:CLOSED: