fix(getPlaylist): populate ArtistID and AlbumID - #567
Merged
Conversation
Contributor
Author
|
Tests fixed.
|
Owner
|
thanks @richardsamuels would you mind rebasing? i also usually format with |
sentriz
reviewed
Mar 24, 2025
| trCh.Genres = append(trCh.Genres, &GenreRef{Name: g.Name}) | ||
| } | ||
| for _, a := range t.Artists { | ||
| if a.Name == t.TagTrackArtist { |
Contributor
Author
There was a problem hiding this comment.
Each TrackChild has a single ArtistID, which corresponds to the TagTrackArtist. The check just makes sure that we assign the correct ArtistID to to the TrackChild. If this check wasn't here, it would assign the track's ArtistID to the last artist in the Artists list
lurenyang418
pushed a commit
to lurenyang418/gonic
that referenced
this pull request
Mar 23, 2026
…licked on Input. (sentriz#567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenSubsonic getPlaylist spec doc lists
artistIdandalbumIdas fields for playlist entries, which are currently not being populated.This PR populates those fields.