Skip to content

feat: fix resourceNames #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2020
Merged

feat: fix resourceNames #24

merged 3 commits into from
Dec 9, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Nov 26, 2019

Fixes #23
@pmakani pmakani requested a review from chingor13 November 26, 2019 07:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@pmakani pmakani changed the title fix resourceNames Nov 26, 2019
@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #24 (2ecbb5b) into master (839f4c5) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     75.17%   75.27%   +0.10%     
- Complexity      593      596       +3     
============================================
  Files            42       42              
  Lines          3646     3661      +15     
  Branches        251      254       +3     
============================================
+ Hits           2741     2756      +15     
  Misses          757      757              
  Partials        148      148
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/logging/Logging.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 88.43% <100.00%> (+0.36%) 76.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839f4c5...2ecbb5b. Read the comment docs.
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
elharo
elharo reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits
@pmakani pmakani changed the title feat(logging) : fix resourceNames Feb 26, 2020
@pmakani pmakani requested a review from elharo February 26, 2020 12:35
@chingor13 chingor13 added this to the 2.0 milestone Apr 3, 2020
@simonz130 simonz130 self-assigned this Dec 9, 2020
@simonz130 simonz130 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2020
@simonz130 simonz130 merged commit 70242d5 into googleapis:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
6 participants
@pmakani @elharo @simonz130 @chingor13 @googlebot @yoshi-kokoro