Skip to content

Conversation

athakor
Copy link
Contributor

@athakor athakor commented May 12, 2020

Fixes #158

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #162 into master will increase coverage by 0.44%.
The diff coverage is 86.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #162      +/-   ##
============================================
+ Coverage     75.17%   75.61%   +0.44%     
- Complexity      593      636      +43     
============================================
  Files            42       43       +1     
  Lines          3646     3794     +148     
  Branches        251      272      +21     
============================================
+ Hits           2741     2869     +128     
- Misses          757      767      +10     
- Partials        148      158      +10     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/logging/Logging.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...om/google/cloud/logging/spi/v2/GrpcLoggingRpc.java 40.17% <0.00%> (-2.56%) 1.00 <0.00> (ø)
.../main/java/com/google/cloud/logging/Exclusion.java 86.04% <86.04%> (ø) 25.00 <25.00> (?)
...ain/java/com/google/cloud/logging/LoggingImpl.java 89.70% <98.18%> (+1.63%) 91.00 <18.00> (+18.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839f4c5...078ab7c. Read the comment docs.

@athakor athakor requested review from chingor13 and codyoss May 12, 2020 11:44
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 20, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 20, 2020
@athakor athakor requested a review from a team June 3, 2020 13:52
@athakor
Copy link
Contributor Author

athakor commented Jun 10, 2020

@chingor13 PTAL

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a major version bump? Are you ready for that?

@chingor13 chingor13 added this to the 2.0 milestone Jun 22, 2020
@athakor athakor force-pushed the logging-exclusions branch from 40e9960 to 5b8422c Compare June 23, 2020 09:00
@athakor
Copy link
Contributor Author

athakor commented Jun 23, 2020

@chingor13 PTAL

@athakor athakor requested a review from simonz130 July 22, 2020 14:54
@athakor
Copy link
Contributor Author

athakor commented Aug 13, 2020

@athakor athakor removed the request for review from codyoss August 31, 2020 08:25
@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2020
@simonz130 simonz130 merged commit 0038828 into googleapis:master Nov 6, 2020
@simonz130 simonz130 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: logging Issues related to the googleapis/java-logging API. labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
6 participants