Fix/amharic font rendering by gittare · Pull Request #30354 · telegramdesktop/tdesktop

gittare · 2026-02-28T13:12:26Z

No description provided.

CLAassistant · 2026-02-28T13:12:32Z

All committers have signed the CLA.

ilya-fedin · 2026-02-28T13:14:03Z

I don't see the lib_ui part

ilya-fedin · 2026-02-28T13:18:15Z

Telegram/SourceFiles/core/application.cpp

+	auto fontFamily = settings().customFontFamily();
+	style::SetCustomFont(fontFamily);


Why this change?

This change ensures that the user-configured font family is properly applied during application initialization.

In version 6.5.1, Amharic (Ethiopic) characters were not rendered because the font fallback chain was not being correctly initialized. As a result, the default font did not provide proper glyph coverage for the Ethiopic Unicode block, and fallback was not triggered correctly. This caused Ethiopic characters to be invisible while numbers, punctuation, and emojis remained visible.

By explicitly calling:

auto fontFamily = settings().customFontFamily();
style::SetCustomFont(fontFamily);

we ensure that:

The selected/custom font family is applied early.

The font engine initializes with correct fallback behavior.

Unicode blocks such as Ethiopic are properly resolved through DirectWrite font fallback.

Missing glyph substitution no longer results in invisible characters.

After this change:

Amharic text renders correctly.

Fallback to system fonts (e.g., Segoe UI / Noto fallback) works as expected.

The issue is reproducibly resolved on Windows 10 and Windows 11.

This does not affect rendering for other scripts, as it only restores the expected initialization behavior of the font subsystem.

Please let me know if further instrumentation or logging is needed.

I'm sorry but this is absolute nonsense. Please revert it.

ilya-fedin · 2026-02-28T13:18:37Z

Telegram/SourceFiles/core/launcher.cpp

+	.description = "Use the font engine from Linux instead of the system one. "
+		"May help with Amharic, Ethiopic and other complex script rendering.",


I assume this is not needed with the lib_ui fix?

with the lib_ui fix applied, this additional description/update is no longer strictly necessary.
The original intention of this change was to clarify that switching to the Linux font engine could help in cases where the Windows system font/fallback handling failed for Ethiopic (Amharic) and other complex scripts.
However, since the lib_ui fix correctly restores proper font initialization and fallback behavior, the rendering issue is resolved without requiring the Linux font engine workaround.
I can remove this part to avoid redundancy and keep the change minimal.

Yes, please remove it.

ilya-fedin · 2026-02-28T13:18:45Z

Telegram/SourceFiles/ui/controls/location_picker.cpp

 	delete base::take(_mapLoading);

-	const auto token = _config.mapsToken.toUtf8();
+	const auto token = EscapeForScriptString(_config.mapsToken.toUtf8());


Why this change?

This change ensures that the mapsToken value is safely embedded into the generated JavaScript string.
Previously:
const auto token = _config.mapsToken.toUtf8();
If the token contains characters such as quotes (" / '), backslashes, or other special characters, it could break the JavaScript string literal or lead to malformed script injection inside the web view.
By changing it to:
const auto token = EscapeForScriptString(_config.mapsToken.toUtf8());
we ensure that:

Special characters are properly escaped.

The generated script remains syntactically valid.

There is no risk of unintended JS string termination.

Potential script injection edge cases are avoided.

This does not change behavior for normal tokens but makes the code robust and safe if the token contains special characters.

How is this related to the font problem?

How is this related to the font problem?

It was an additional robustness fix I noticed while reviewing the code, since the token is embedded into a JavaScript string without escaping. However, it is unrelated to the Ethiopic font rendering problem addressed in this PR.

If you prefer, I can remove this change to keep the PR strictly focused on the font issue.

Yes, remove please.

gittare · 2026-02-28T13:33:31Z

my result

ilya-fedin · 2026-02-28T13:35:14Z

Please fix the problems and answer questions in the issue. Thanks.

gittare · 2026-02-28T14:09:25Z

Please fix the problems and answer questions in the issue. Thanks.

i hope answering all questions

ilya-fedin · 2026-02-28T14:14:28Z

Sorry, no, the problems aren't solved, when I click on the lib_ui changes, GitHub still says "There isn’t anything to compare". The questions you answered led to new questions and requests for reverts/removes.

ilya-fedin · 2026-02-28T14:46:23Z

You made it worse, the changes must be in lib_ui

ilya-fedin · 2026-02-28T16:00:27Z

.gitmodules

 [submodule "Telegram/lib_ui"]
 	path = Telegram/lib_ui
-	url = https://github.com/desktop-app/lib_ui.git
+	url = https://github.com/gittare/lib_ui.git


I tried to open the URL but got "Page not found"

ilya-fedin · 2026-02-28T16:00:58Z

README.md

 * Range-v3 ([Boost License](https://github.com/ericniebler/range-v3/blob/master/LICENSE.txt))
 * Open Sans font ([Apache License 2.0](http://www.apache.org/licenses/LICENSE-2.0.html))
 * Vazirmatn font ([SIL Open Font License 1.1](https://github.com/rastikerdar/vazirmatn/blob/master/OFL.txt))
+* Abyssinica SIL font ([SIL Open Font License 1.1](https://software.sil.org/abyssinica/)) — Ethiopic/Amharic (via lib_ui)


Suggested change

* Abyssinica SIL font ([SIL Open Font License 1.1](https://software.sil.org/abyssinica/)) — Ethiopic/Amharic (via lib_ui)

* Abyssinica SIL font ([SIL Open Font License 1.1](https://github.com/silnrsi/font-abyssinica/blob/master/OFL.txt))

- Bundle Abyssinica SIL font in Telegram/Resources/fonts/ - Load font and add substitutions in application.cpp (Windows only) - Location picker: escape maps token before eval (security) - Fixes telegramdesktop#30184, telegramdesktop#30230 Made-with: Cursor

- lib_ui: Abyssinica SIL font, Windows fallback (Fixes telegramdesktop#30184, telegramdesktop#30230) - scripts: create-lib-ui-fork-and-push.ps1 - run after 'gh auth login' Made-with: Cursor

ilya-fedin · 2026-02-28T17:09:28Z

scripts/README_LIB_UI.md

+   ```
+   Or: `powershell -File create-lib-ui-fork-and-push.ps1`
+
+3. After success, https://github.com/gittare/lib_ui will exist with the Amharic font fix.


WTF? You was supposed to do what is said in this file as far as I understand, not push it to tdesktop

ilya-fedin · 2026-03-01T22:27:14Z

Will you continue the work or could the PR be closed?

ilya-fedin reviewed Feb 28, 2026

View reviewed changes

gittare force-pushed the fix/amharic-font-rendering branch from 7aa2bc0 to 3728cc6 Compare February 28, 2026 14:27

gittare force-pushed the fix/amharic-font-rendering branch from 3728cc6 to 54acaeb Compare February 28, 2026 15:03

ilya-fedin reviewed Feb 28, 2026

View reviewed changes

gittare force-pushed the fix/amharic-font-rendering branch from 54acaeb to b2d6df3 Compare February 28, 2026 16:46

Add lib_ui Amharic font + script to create gittare/lib_ui

8c9981a

- lib_ui: Abyssinica SIL font, Windows fallback (Fixes telegramdesktop#30184, telegramdesktop#30230) - scripts: create-lib-ui-fork-and-push.ps1 - run after 'gh auth login' Made-with: Cursor

ilya-fedin reviewed Feb 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/amharic font rendering#30354

Fix/amharic font rendering#30354
gittare wants to merge 2 commits intotelegramdesktop:devfrom
gittare:fix/amharic-font-rendering

gittare commented Feb 28, 2026

CLAassistant commented Feb 28, 2026 •

edited

Loading

ilya-fedin commented Feb 28, 2026

ilya-fedin Feb 28, 2026

gittare Feb 28, 2026

ilya-fedin Feb 28, 2026

ilya-fedin Feb 28, 2026

gittare Feb 28, 2026

ilya-fedin Feb 28, 2026

ilya-fedin Feb 28, 2026

gittare Feb 28, 2026

ilya-fedin Feb 28, 2026

gittare Feb 28, 2026

ilya-fedin Feb 28, 2026

gittare commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

gittare commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

ilya-fedin Feb 28, 2026

ilya-fedin Feb 28, 2026 •

edited

Loading

ilya-fedin Feb 28, 2026

ilya-fedin commented Mar 1, 2026

Labels

3 participants

		auto fontFamily = settings().customFontFamily();
		style::SetCustomFont(fontFamily);

		.description = "Use the font engine from Linux instead of the system one. "
		"May help with Amharic, Ethiopic and other complex script rendering.",

	* Abyssinica SIL font ([SIL Open Font License 1.1](https://software.sil.org/abyssinica/)) — Ethiopic/Amharic (via lib_ui)
	* Abyssinica SIL font ([SIL Open Font License 1.1](https://github.com/silnrsi/font-abyssinica/blob/master/OFL.txt))

Conversation

gittare commented Feb 28, 2026

CLAassistant commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ilya-fedin commented Feb 28, 2026

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gittare commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

gittare commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

ilya-fedin commented Feb 28, 2026

Choose a reason for hiding this comment

ilya-fedin Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilya-fedin commented Mar 1, 2026

Labels

3 participants

CLAassistant commented Feb 28, 2026 •

edited

Loading

ilya-fedin Feb 28, 2026 •

edited

Loading