Add and use RichText::remove_unallowed_quote_entities.

Author: levlam

td/telegram/MessageQuote.cpp

@@ -32,6 +32,9 @@ static vector<RichText> get_quote_rich_texts(
   vector<RichText> result;
   for (auto &rich_text_ptr : rich_text_ptrs) {
     RichText rich_text(std::move(rich_text_ptr), FlatHashMap<int64, FileId>());
+    if (rich_text.remove_unallowed_quote_entities()) {
+      LOG(ERROR) << "Receive a rich quote with unexpected entities";
+    }
     if (!rich_text.empty()) {
       result.push_back(std::move(rich_text));
     }
@@ -111,6 +114,19 @@ MessageQuote::MessageQuote(Td *td, td_api::object_ptr<td_api::inputTextQuote> qu
   }
 }
 
+bool MessageQuote::remove_unallowed_quote_entities_from_rich_texts(vector<RichText> &rich_texts) {
+  bool is_changed = false;
+  for (auto &rich_text : rich_texts) {
+    if (rich_text.remove_unallowed_quote_entities()) {
+      is_changed = true;
+    }
+  }
+  if (td::remove_if(rich_texts, [](const RichText &rich_text) { return rich_text.empty(); })) {
+    is_changed = true;
+  }
+  return is_changed;
+}
+
 MessageQuote MessageQuote::clone(Td *td, DialogId dialog_id, MessageContentDupType dup_type,
                                  bool ignore_is_manual) const {
   CloneWebPageBlockContext context;

td/telegram/MessageQuote.h

@@ -30,6 +30,8 @@ class MessageQuote {
 
   vector<td_api::object_ptr<td_api::RichText>> get_rich_texts_object(Td *td) const;
 
+  static bool remove_unallowed_quote_entities_from_rich_texts(vector<RichText> &rich_texts);
+
   friend bool operator==(const MessageQuote &lhs, const MessageQuote &rhs);
 
   friend StringBuilder &operator<<(StringBuilder &string_builder, const MessageQuote &quote);
@@ -45,6 +47,7 @@ class MessageQuote {
   MessageQuote(FormattedText &&text, vector<RichText> &&rich_texts, int32 position, bool is_manual = true)
       : text_(std::move(text)), rich_texts_(std::move(rich_texts)), position_(max(0, position)), is_manual_(is_manual) {
     remove_unallowed_quote_entities(text_);
+    remove_unallowed_quote_entities_from_rich_texts(rich_texts_);
   }
 
   MessageQuote(Td *td, telegram_api::object_ptr<telegram_api::inputReplyToMessage> &input_reply_to_message);

td/telegram/MessageQuote.hpp

@@ -56,6 +56,7 @@ void MessageQuote::parse(ParserT &parser) {
   }
   if (has_rich_texts) {
     td::parse(rich_texts_, parser);
+    remove_unallowed_quote_entities_from_rich_texts(rich_texts_);
   }
 }
 

td/telegram/RichText.cpp

@@ -713,6 +713,74 @@ RichText RichText::get_quote_fragment_impl(size_t &pos, size_t begin, size_t end
   }
 }
 
+bool RichText::remove_unallowed_quote_entities() {
+  switch (type_) {
+    case Type::Plain:
+    case Type::Math:
+    case Type::CustomEmoji:
+      return false;
+    case Type::Icon:
+      // icons can't be quoted
+      *this = RichText();
+      return true;
+    case Type::Concatenation: {
+      bool is_changed = false;
+      for (auto &text : texts_) {
+        if (text.remove_unallowed_quote_entities()) {
+          is_changed = true;
+        }
+      }
+      if (td::remove_if(texts_, [](const RichText &text) { return text.empty(); })) {
+        is_changed = true;
+      }
+      if (texts_.empty()) {
+        *this = RichText();
+        return true;
+      }
+      return is_changed;
+    }
+    case Type::Fixed:
+    case Type::Url:
+    case Type::EmailAddress:
+    case Type::Marked:
+    case Type::PhoneNumber:
+    case Type::Anchor:
+    case Type::Mention:
+    case Type::Hashtag:
+    case Type::Cashtag:
+    case Type::BotCommand:
+    case Type::AutoUrl:
+    case Type::AutoEmailAddress:
+    case Type::AutoPhoneNumber:
+    case Type::BankCardNumber:
+    case Type::MentionName:
+    case Type::Button:
+    case Type::TonAddress:
+    case Type::Diff: {
+      // the formatting isn't supported in quotes, so only the text is kept
+      CHECK(!texts_.empty());
+      auto text = std::move(texts_[0]);
+      text.remove_unallowed_quote_entities();
+      *this = std::move(text);
+      return true;
+    }
+    default:
+      if (texts_.size() != 1u) {
+        LOG(ERROR) << "Receive rich text of type " << static_cast<int32>(type_) << " with " << texts_.size()
+                   << " texts";
+        *this = RichText();
+        return true;
+      }
+      if (!texts_[0].remove_unallowed_quote_entities()) {
+        return false;
+      }
+      if (texts_[0].empty()) {
+        *this = RichText();
+      }
+      return true;
+  }
+}
+
 int32 RichText::get_index_mask() const {
   switch (type_) {
     case Type::Url:

td/telegram/RichText.h

@@ -110,6 +110,9 @@ class RichText {
   // returns part of the rich text between begin and end UTF-8 characters of its quote text, which can be used in a quote
   RichText get_quote_fragment(size_t begin, size_t end) const;
 
+  // removes formatting, which isn't supported in quotes; returns true, if the text was changed
+  bool remove_unallowed_quote_entities();
+
   int32 get_index_mask() const;
 
   void append_user_ids(vector<UserId> &user_ids) const;