You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 04bff39
Browse filesBrowse the repository at this point in the historyBrowse files
Chat: an unread reaction taken off leaves the badge, Read all reactions works the first time, emoji suggestions are never an empty strip, the emoji panel drops thumbnails on reopening, search highlights land on their words
Four bugs, each with its cause:
- Unread reactions: the last reaction taken off comes in an updateMessageReactions without `recent_reactions`,
which made the message's unread state `undefined`, and the counter was never brought down. It is a boolean now;
a `min` object, which leaves the recent reactions out whatever they are, keeps the state it had.
- Read all reactions (and mentions, and poll votes) brought the counter down by a negative number, which the
cached list of unread messages took for an addition: it put `undefined` into the list and threw after the
counter was zeroed but before the chat was told, so the badge stayed until a second try. A negative count now
clears the list.
- Emoji suggestions: the custom emoji a user without Premium cannot use in the chat were dropped after the strip
had decided to show, so a query whose answers were all such emoji showed an empty strip; and they were dropped
after the 40 answers were cut, taking the places of the emoji that can be used. They are dropped first now, the
same way the suggestions for a typed emoji already were.
- Emoji panel: a category going out of sight puts thumbnails on its custom emoji, which rejoin the same group in
the same pass. The group was still taken for drawn, so once the category was shown again its thumbnails were
never cleared and showed under the emoji. Thumbnails put on a drawn group now show it by its placeholders again,
as one leaving the viewport does.
- Search highlight: opening a chat at a found message lit its words up while the bubbles were still zooming in
(scale .8 to 1), measuring them at that scale, and nothing measured them again - the highlight stood off its
words. The highlight (and the flash) of a jump now waits for the zoom of a list rendered anew, which never keeps
it waiting when the zoom does not come; and the line boxes are measured in the bubble's own pixels, whatever
scale an ancestor has.
- Tests: the reaction counter on a reaction taken off, on a `min` update and on Read all; line boxes under a
scaled ancestor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0 commit comments