Skip to content

feat: ad-hoc, targeted debug logging #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 22, 2025
Merged

feat: ad-hoc, targeted debug logging #2062

merged 13 commits into from
Jul 22, 2025

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jul 3, 2025 •
edited
Loading

This feature will add the ability to selectively enable "printf debugging" output for diagnostic introspection. This uses the new standard Google ad-hoc debug logging infrastructure introduced a few months back.

Samples:

GOOGLE_SDK_NODE_LOGGING=pubsub:*

All hand-written logic on top of the auto-generated RPCs.

GOOGLE_SDK_NODE_LOGGING=pubsub*

All logging related to Pub/Sub (including the RPCs).

GOOGLE_SDK_NODE_LOGGING=*

All logging, including things like auth.

A fuller guide will be forthcoming.
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jul 3, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jul 3, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025
@feywind feywind marked this pull request as ready for review July 3, 2025 23:06
@feywind feywind requested review from a team as code owners July 3, 2025 23:06
hongalex
hongalex reviewed Jul 8, 2025
View reviewed changes
hongalex
hongalex reviewed Jul 9, 2025
View reviewed changes
feywind and others added 2 commits July 16, 2025 13:38
@feywind
fix: clear up what 99th percentile means
6cc83d5
@feywind @hongalex
fix: use the grpc constants instead of a number
23c9de5 
Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com>
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 16, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 16, 2025
hongalex
hongalex reviewed Jul 16, 2025
View reviewed changes
sofisl
sofisl reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sofisl sofisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same general comment about private elements
hongalex
hongalex previously approved these changes Jul 21, 2025
View reviewed changes
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2025
@feywind feywind merged commit dce83c7 into main Jul 22, 2025
19 of 20 checks passed
@feywind feywind deleted the adhoc-logging branch July 22, 2025 17:19
@release-please release-please bot mentioned this pull request Jul 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xl Pull request size is extra large.
3 participants
@feywind @hongalex @sofisl