Skip to content

feat(pubsub): use Streaming Pull response for ordering check #9682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat(pubsub): use Streaming Pull response for ordering check #9682

merged 5 commits into from
Apr 9, 2024

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Apr 1, 2024

This PR switches the ordering check on subscription away from the GetSubscription call to reading the ordering field of the StreamingPull response instead.

Fixes #9374
@hongalex hongalex requested review from shollyman and a team as code owners April 1, 2024 22:37
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 1, 2024
@alvarowolfx alvarowolfx self-requested a review April 8, 2024 21:11
alvarowolfx
alvarowolfx approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but looks good to me.
@hongalex hongalex enabled auto-merge (squash) April 9, 2024 00:22
@hongalex hongalex merged commit 7bf4904 into googleapis:main Apr 9, 2024
@release-please release-please bot mentioned this pull request Apr 9, 2024
Merged
@hongalex hongalex deleted the pubsub-remove-get-subscription-ordering branch April 9, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
3 participants
@hongalex @alvarowolfx @kamalaboulhosn