Skip to content

fix(pubsub): set x-goog-request-params for streaming pull request #8753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix(pubsub): set x-goog-request-params for streaming pull request #8753

merged 3 commits into from
Oct 31, 2023

Conversation

kamalaboulhosn
Copy link
Contributor

This is set in the generated client for non-streaming requests, but cannot be for streaming requests, so we have to set it manually.
@kamalaboulhosn kamalaboulhosn requested review from shollyman and a team as code owners October 20, 2023 16:53
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the Pub/Sub API. labels Oct 20, 2023
@kamalaboulhosn kamalaboulhosn merged commit 21ec815 into googleapis:main Oct 31, 2023
@release-please release-please bot mentioned this pull request Oct 31, 2023
Merged
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
@kamalaboulhosn @bhshkh
fix(pubsub): set x-goog-request-params for streaming pull request (#8753
40796ca 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: xs Pull request size is extra small.
2 participants
@kamalaboulhosn @shollyman