Skip to content

docs: fix broken BEM link and update Flux link to HTTPS - #12622

Closed
kxrn-gupta wants to merge 2 commits into
meta:mainfrom
kxrn-gupta:docs/fix-outdated-and-broken-links
Closed

kxrn-gupta wants to merge 2 commits into
meta:mainfrom
kxrn-gupta:docs/fix-outdated-and-broken-links

Conversation

@kxrn-gupta

Copy link
Copy Markdown

Motivation

  1. In \website/docs/styling-layout.mdx, the link to \http://getbem.com/naming/\ is dead (domain fails to resolve). Replaced it with the canonical Wikipedia BEM article reference.
  2. In \website/docs/migration/v2/migration-manual.mdx, updated \http://facebook.github.io/flux/support\ to HTTPS.

Test Plan

  • Checked link targets to verify they resolve to valid HTTP 200 URLs.
  • Documentation change only.
@meta-cla

meta-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Hi @karan5028ji!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d255cc
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6ac926f3600604000761b2a7
😎 Deploy Preview https://deploy-preview-12622--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread website/docs/styling-layout.mdx Outdated

- **Theme class names**. These class names are listed exhaustively in [the next subsection](#theme-class-names). They don't have any default properties. You should always prioritize targeting those stable class names in your custom CSS.
- **Infima class names**. These class names are found in the classic theme and usually follow the [BEM convention](http://getbem.com/naming/) of `block__element--modifier`. They are usually stable but are still considered implementation details, so you should generally avoid targeting them. However, you can [modify Infima CSS variables](#styling-your-site-with-infima).
- **Infima class names**. These class names are found in the classic theme and usually follow the [BEM convention](https://en.wikipedia.org/wiki/BEM) of `block__element--modifier`. They are usually stable but are still considered implementation details, so you should generally avoid targeting them. However, you can [modify Infima CSS variables](#styling-your-site-with-infima).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Infima class names**. These class names are found in the classic theme and usually follow the [BEM convention](https://en.wikipedia.org/wiki/BEM) of `block__element--modifier`. They are usually stable but are still considered implementation details, so you should generally avoid targeting them. However, you can [modify Infima CSS variables](#styling-your-site-with-infima).
- **Infima class names**. These class names are found in the classic theme and usually follow the [BEM convention](https://css-tricks.com/bem-101/) of `block__element--modifier`. They are usually stable but are still considered implementation details, so you should generally avoid targeting them. However, you can [modify Infima CSS variables](#styling-your-site-with-infima).

That Wikipedia article doesn't say anything

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Oct 9, 2026
@kxrn-gupta

Copy link
Copy Markdown
Author

Updated with the CSS-Tricks BEM reference as suggested. Thank you @Josh-Cena!

@kxrn-gupta kxrn-gupta closed this by deleting the head repository Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

2 participants