Extract RunOnce into a dedicated class #35489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jasontedor
approved these changes
Nov 14, 2018
tlrx
force-pushed
the
relocate-add-once
branch
from
df46faa to
016984a
Compare
tlrx
force-pushed
the
relocate-add-once
branch
from
016984a to
f8719e3
Compare
|
Thanks @jasontedor |
tlrx
added a commit
that referenced
this pull request
Nov 14, 2018
This commit extracts the static inner class RunOnce from WorkerBulkByScrollTaskState so that it can be reused at other places.
tlrx
added a commit
that referenced
this pull request
Nov 15, 2018
This pull request replaces some blocks of code that must be run once and that are currently based on AtomicBoolean by the convient RunOnce class added in #35489.
tlrx
added a commit
that referenced
this pull request
Nov 15, 2018
This pull request replaces some blocks of code that must be run once and that are currently based on AtomicBoolean by the convient RunOnce class added in #35489.
|
Thanks @tlrx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extracts the static inner class
RunOncefromWorkerBulkByScrollTaskStateso that it can be reused at other places. It also adds tests.