Fix chat folder duplication regression on tab switch

Root cause: isActiveForFolderPagination defaulted back to true (e2ed943),
so adjacent preloaded folder tabs paginated in background and corrupted list
state when switched to.

- Default pagination gate to false; opt in for standalone lists
- Explicitly gate adjacent itemNodes in ChatListContainerNode.update
- deactivateFolderPagination() resets navigation on tab switch-out
- Apply-time locationGeneration guard in dequeueTransition
- Honor animated:false on switchToFilter (tab taps use immediate transition)

Co-authored-by: D3C0Y <decoder-dev@users.noreply.github.com>

Author: decoder-dev

submodules/ChatListUI/Sources/ChatListControllerNode.swift

@@ -177,7 +177,7 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
             previousItemNode.listNode.addedVisibleChatsWithPeerIds = nil
             previousItemNode.listNode.didBeginSelectingChats = nil
             previousItemNode.listNode.canExpandHiddenItems = nil
-            previousItemNode.listNode.isActiveForFolderPagination = false
+            previousItemNode.listNode.deactivateFolderPagination()
 
             previousItemNode.accessibilityElementsHidden = true
         }
@@ -906,7 +906,7 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
 
                 self.selectedId = id
                 self.applyItemNodeAsCurrent(id: id, itemNode: itemNode)
-                let transition: ContainedViewLayoutTransition = .animated(duration: 0.35, curve: .spring)
+                let transition: ContainedViewLayoutTransition = animated ? .animated(duration: 0.35, curve: .spring) : .immediate
                 self.update(layout: layout, navigationBarHeight: navigationBarHeight, visualNavigationHeight: visualNavigationHeight, originalNavigationHeight: originalNavigationHeight, cleanNavigationBarHeight: cleanNavigationBarHeight, insets: insets, isReorderingFilters: isReorderingFilters, isEditing: isEditing, inlineNavigationLocation: inlineNavigationLocation, inlineNavigationTransitionFraction: inlineNavigationTransitionFraction, storiesInset: storiesInset, transition: transition)
                 self.currentItemFilterUpdated?(self.currentItemFilter, self.transitionFraction, transition, false)
                 self.pinnedHeaderDisplayFractionUpdated?(transition)
@@ -922,6 +922,7 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
                 }, openArchiveSettings: { [weak self] in
                     self?.openArchiveSettings()
                 }, autoSetReady: !animated, isMainTab: index == 0)
+                itemNode.listNode.isActiveForFolderPagination = false
                 self.pendingItemNode?.2.dispose()
                 let disposable = MetaDisposable()
                 self.pendingItemNode = (id, itemNode, disposable)
@@ -1077,6 +1078,7 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
                         self?.openArchiveSettings()
                     }, autoSetReady: false, isMainTab: i == 0)
                     itemNode.listNode.tempTopInset = self.tempTopInset
+                    itemNode.listNode.isActiveForFolderPagination = false
                     self.itemNodes[id] = itemNode
                 }
             }
@@ -1115,6 +1117,7 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
                 }
 
                 itemNode.listNode.isMainTab.set(self.availableFilters.firstIndex(where: { $0.id == id }) == 0)
+                itemNode.listNode.isActiveForFolderPagination = (id == self.selectedId)
                 itemNode.updateLayout(size: layout.size, insets: insets, visualNavigationHeight: visualNavigationHeight, originalNavigationHeight: originalNavigationHeight, inlineNavigationLocation: inlineNavigationLocation, inlineNavigationTransitionFraction: itemInlineNavigationTransitionFraction, storiesInset: storiesInset, transition: nodeTransition)
                 if let scrollingOffset = self.scrollingOffset {
                     itemNode.updateScrollingOffset(navigationHeight: scrollingOffset.navigationHeight, offset: scrollingOffset.offset, transition: nodeTransition)

submodules/ChatListUI/Sources/Node/ChatListNode.swift

@@ -48,6 +48,7 @@ struct ChatListNodeListViewTransition {
     let stationaryItemRange: (Int, Int)?
     let adjustScrollToFirstItem: Bool
     let animateCrossfade: Bool
+    let locationGeneration: Int
 }
 
 final class ChatListHighlightedLocation: Equatable {
@@ -1171,9 +1172,10 @@ private func mappedChatListNodeViewListTransition(
     mode: ChatListNodeMode,
     isPeerEnabled: ((EnginePeer) -> Bool)?,
     presentationData: ChatListPresentationData,
-    transition: ChatListNodeViewTransition
+    transition: ChatListNodeViewTransition,
+    locationGeneration: Int
 ) -> ChatListNodeListViewTransition {
-    return ChatListNodeListViewTransition(chatListView: transition.chatListView, deleteItems: transition.deleteItems, insertItems: mappedInsertEntries(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: isPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, entries: transition.insertEntries, presentationData: presentationData), updateItems: mappedUpdateEntries(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: isPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, entries: transition.updateEntries, presentationData: presentationData), options: transition.options, scrollToItem: transition.scrollToItem, stationaryItemRange: transition.stationaryItemRange, adjustScrollToFirstItem: transition.adjustScrollToFirstItem, animateCrossfade: transition.animateCrossfade)
+    return ChatListNodeListViewTransition(chatListView: transition.chatListView, deleteItems: transition.deleteItems, insertItems: mappedInsertEntries(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: isPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, entries: transition.insertEntries, presentationData: presentationData), updateItems: mappedUpdateEntries(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: isPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, entries: transition.updateEntries, presentationData: presentationData), options: transition.options, scrollToItem: transition.scrollToItem, stationaryItemRange: transition.stationaryItemRange, adjustScrollToFirstItem: transition.adjustScrollToFirstItem, animateCrossfade: transition.animateCrossfade, locationGeneration: locationGeneration)
 }
 
 private final class ChatListOpaqueTransactionState {
@@ -1300,16 +1302,9 @@ public final class ChatListNode: ListViewImpl {
 
     private var currentLocation: ChatListNodeLocation?
     private var chatListLocationGeneration: Int = 0
-    /// Gates `displayedItemRangeChanged` — pagination, history preload and story-peer refresh.
-    ///
-    /// Defaults to true. `ChatListContainerNode` turns it off on the tab being switched away from
-    /// and back on for the one becoming current, which is the folder-duplication fix; but not every
-    /// `ChatListNode` lives in that container. `PeerSelectionControllerNode` (Forward to…) and
-    /// `ContactMultiselectionControllerNode` (add members) build one directly and never call
-    /// `reconcileLocationOnTabActivation`, so defaulting to false left those lists stuck on their
-    /// first window — scrolling down simply ran out of chats. True is also what every list did
-    /// before the gate existed, so this only ever narrows behaviour relative to that.
-    var isActiveForFolderPagination: Bool = true
+    /// Defaults to false. Only the visible folder tab (or standalone lists that opt in) may paginate;
+    /// adjacent preloaded tabs must stay false or background pagination corrupts their item state.
+    var isActiveForFolderPagination: Bool = false
     public private(set) var chatListFilter: ChatListFilter? {
         didSet {
             self.chatListFilterValue.set(.single(self.chatListFilter))
@@ -2735,7 +2730,7 @@ public final class ChatListNode: ListViewImpl {
             let presentationData = state.presentationData
 
             return preparedChatListNodeViewTransition(from: previousView, to: processedView, reason: reason, previewing: previewing, disableAnimations: disableAnimations, scrollPosition: updatedScrollPosition, searchMode: searchMode, forceAllUpdated: forceAllUpdated)
-            |> map({ mappedChatListNodeViewListTransition(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: accountIsPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, presentationData: presentationData, transition: $0) })
+            |> map({ mappedChatListNodeViewListTransition(context: context, nodeInteraction: nodeInteraction, location: location, isPremium: accountIsPremium, filterData: filterData, chatListFilters: chatListFilters, mode: mode, isPeerEnabled: isPeerEnabled, presentationData: presentationData, transition: $0, locationGeneration: locationGeneration) })
             |> runOn(prepareOnMainQueue ? Queue.mainQueue() : viewProcessingQueue)
         }
 
@@ -3427,6 +3422,11 @@ public final class ChatListNode: ListViewImpl {
         if let (transition, completion) = self.enqueuedTransition {
             self.enqueuedTransition = nil
 
+            guard transition.locationGeneration == self.chatListLocationGeneration, self.isActiveForFolderPagination else {
+                completion()
+                return
+            }
+            
             let completion: (ListViewDisplayedItemRange) -> Void = { [weak self] visibleRange in
                 if let strongSelf = self {
                     strongSelf.chatListView = transition.chatListView
@@ -3825,6 +3825,13 @@ public final class ChatListNode: ListViewImpl {
         }
     }
 
+    func deactivateFolderPagination() {
+        self.isActiveForFolderPagination = false
+        if case .navigation = self.currentLocation {
+            self.setChatListLocation(.initial(count: 50, filter: self.chatListFilter))
+        }
+    }
+    
     func reconcileLocationOnTabActivation() {
         self.isActiveForFolderPagination = true
         if case .navigation = self.currentLocation {

submodules/TelegramUI/Components/PeerInfo/PeerInfoChatListPaneNode/Sources/PeerInfoChatListPaneNode.swift

@@ -172,6 +172,7 @@ public final class PeerInfoChatListPaneNode: ASDisplayNode, PeerInfoPaneNode, AS
             autoSetReady: false,
             isMainTab: nil
         )
+        self.chatListNode.isActiveForFolderPagination = true
         self.chatListNode.synchronousDrawingWhenNotAnimated = true
 
         super.init()

submodules/TelegramUI/Components/PeerSelectionController/Sources/PeerSelectionControllerNode.swift

@@ -247,6 +247,7 @@ final class PeerSelectionControllerNode: ASDisplayNode {
         } else {
             self.mainContainerNode = nil
             self.chatListNode = ChatListNode(context: context, location: chatListLocation, previewing: false, fillPreloadItems: false, mode: chatListMode, theme: self.presentationData.theme, fontSize: presentationData.listsFontSize, strings: presentationData.strings, dateTimeFormat: presentationData.dateTimeFormat, nameSortOrder: presentationData.nameSortOrder, nameDisplayOrder: presentationData.nameDisplayOrder, animationCache: self.animationCache, animationRenderer: self.animationRenderer, disableAnimations: true, isInlineMode: false, autoSetReady: true, isMainTab: false)
+            self.chatListNode?.isActiveForFolderPagination = true
             if let multipleSelectionLimit = controller.multipleSelectionLimit {
                 self.chatListNode?.selectionLimit = multipleSelectionLimit
             }

submodules/TelegramUI/Sources/ContactMultiselectionControllerNode.swift

@@ -189,6 +189,7 @@ final class ContactMultiselectionControllerNode: ASDisplayNode {
 
             placeholder = placeholderValue
             let chatListNode = ChatListNode(context: context, location: .chatList(groupId: .root), chatListFilter: chatListFilter, previewing: false, fillPreloadItems: false, mode: .peers(filter: [.excludeSecretChats], isSelecting: true, additionalCategories: additionalCategories?.categories ?? [], topPeers: [], chatListFilters: chatListFilters, displayAutoremoveTimeout: chatSelection.displayAutoremoveTimeout, displayPresence: chatSelection.displayPresence), isPeerEnabled: isPeerEnabled, theme: self.presentationData.theme, fontSize: self.presentationData.listsFontSize, strings: self.presentationData.strings, dateTimeFormat: self.presentationData.dateTimeFormat, nameSortOrder: self.presentationData.nameSortOrder, nameDisplayOrder: self.presentationData.nameDisplayOrder, animationCache: self.animationCache, animationRenderer: self.animationRenderer, disableAnimations: true, isInlineMode: false, autoSetReady: true, isMainTab: false)
+            chatListNode.isActiveForFolderPagination = true
             chatListNode.passthroughPeerSelection = true
             chatListNode.disabledPeerSelected = { peer, _, reason in
                 attemptDisabledItemSelection?(peer, reason)