Fix chat folder duplication when switching Personal to All Chats

Root cause: background All Chats node kept paginating and applying stale
transitions while Personal was selected. mapToQueue work from superseded
location generations could merge against a desynced previousView.

- Drop stale transitions when chatListLocationGeneration advances
- Pause pagination on non-active folder tabs
- Reset paginated location when a tab becomes active again
- Force full list refresh when filter context changes
- Stop scroll-syncing off-screen tabs during folder pan
- Track selectTab async with MetaDisposable + generation guard

Co-authored-by: D3C0Y <decoder-dev@users.noreply.github.com>

Author: decoder-dev

submodules/ChatListUI/Sources/ChatListController.swift

@@ -152,6 +152,8 @@ public class ChatListControllerImpl: TelegramBaseController, ChatListController
 
     private let stateDisposable = MetaDisposable()
     private let filterDisposable = MetaDisposable()
+    private let selectTabDisposable = MetaDisposable()
+    private var selectTabGeneration: Int = 0
     private let extrasFoldersDisposable = MetaDisposable()
     private var skipExtrasFoldersReload = false
     private let featuredFiltersDisposable = MetaDisposable()
@@ -4228,9 +4230,11 @@ public class ChatListControllerImpl: TelegramBaseController, ChatListController
             }
         }
 
-        let _ = (self.context.engine.peers.currentChatListFilters()
-        |> deliverOnMainQueue).startStandalone(next: { [weak self] filters in
-            guard let strongSelf = self else {
+        self.selectTabGeneration &+= 1
+        let generation = self.selectTabGeneration
+        self.selectTabDisposable.set((self.context.engine.peers.currentChatListFilters()
+        |> deliverOnMainQueue).startStrict(next: { [weak self] filters in
+            guard let strongSelf = self, generation == strongSelf.selectTabGeneration else {
                 return
             }
             let updatedFilter: ChatListFilter?
@@ -4261,7 +4265,7 @@ public class ChatListControllerImpl: TelegramBaseController, ChatListController
                 }
                 strongSelf.chatListDisplayNode.mainContainerNode.switchToAvailableFilter(preferring: updatedFilter.flatMap { .filter($0.id) } ?? .all, animated: false)
             }
-        })
+        }))
     }
 
     private func readAllInFilter(id: Int32) {

submodules/ChatListUI/Sources/ChatListControllerNode.swift

@@ -177,11 +177,13 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
             previousItemNode.listNode.addedVisibleChatsWithPeerIds = nil
             previousItemNode.listNode.didBeginSelectingChats = nil
             previousItemNode.listNode.canExpandHiddenItems = nil
+            previousItemNode.listNode.isActiveForFolderPagination = false
 
             previousItemNode.accessibilityElementsHidden = true
         }
         self.currentItemNodeValue = itemNode
         itemNode.accessibilityElementsHidden = false
+        itemNode.listNode.reconcileLocationOnTabActivation()
 
         itemNode.listNode.activateSearch = { [weak self] in
             self?.activateSearch?()
@@ -607,12 +609,6 @@ public final class ChatListContainerNode: ASDisplayNode, ASGestureRecognizerDele
                 for (id, itemNode) in self.itemNodes {
                     if id != selectedId {
                         itemNode.emptyNode?.restartAnimation()
-                        
-                        if let controller = self.controller, let chatListDisplayNode = controller.displayNode as? ChatListControllerNode, let navigationBarComponentView = chatListDisplayNode.navigationBarView.view as? ChatListNavigationBar.View, let clippedScrollOffset = navigationBarComponentView.clippedScrollOffset {
-                            let scrollOffset = clippedScrollOffset
-                            
-                            let _ = itemNode.listNode.scrollToOffsetFromTop(scrollOffset, animated: false)
-                        }
                     }
                 }
 

submodules/ChatListUI/Sources/Node/ChatListNode.swift

@@ -1299,6 +1299,8 @@ public final class ChatListNode: ListViewImpl {
     }
 
     private var currentLocation: ChatListNodeLocation?
+    private var chatListLocationGeneration: Int = 0
+    var isActiveForFolderPagination: Bool = false
     public private(set) var chatListFilter: ChatListFilter? {
         didSet {
             self.chatListFilterValue.set(.single(self.chatListFilter))
@@ -1930,10 +1932,14 @@ public final class ChatListNode: ListViewImpl {
 
         let chatListViewUpdate = self.chatListLocation.get()
         |> distinctUntilChanged
-        |> mapToSignal { listLocation -> Signal<(ChatListNodeViewUpdate, ChatListFilter?), NoError> in
+        |> mapToSignal { [weak self] listLocation -> Signal<(ChatListNodeViewUpdate, ChatListFilter?, Int), NoError> in
+            guard let strongSelf = self else {
+                return .complete()
+            }
+            let locationGeneration = strongSelf.chatListLocationGeneration
             return chatListViewForLocation(chatListLocation: location, location: listLocation, account: context.account, shouldLoadCanMessagePeer: shouldLoadCanMessagePeer)
             |> map { update in
-                return (update, listLocation.filter)
+                return (update, listLocation.filter, locationGeneration)
             }
         }
 
@@ -1963,7 +1969,7 @@ public final class ChatListNode: ListViewImpl {
         |> distinctUntilChanged
 
         let chatListViewUpdateForFilters = combineLatest(chatListViewUpdate, messageFilterSettings)
-        |> map { update, _ -> (ChatListNodeViewUpdate, ChatListFilter?) in
+        |> map { update, _ -> (ChatListNodeViewUpdate, ChatListFilter?, Int) in
             return update
         }
 
@@ -2229,8 +2235,14 @@ public final class ChatListNode: ListViewImpl {
             chatListFilters,
             accountIsPremium
         )
-        |> mapToQueue { (hideArchivedFolderByDefault, archiveFolderPresentation, displayArchiveIntro, storageInfo, savedMessagesPeer, updateAndFilter, state, contacts, chatListFilters, accountIsPremium) -> Signal<ChatListNodeListViewTransition, NoError> in
-            let (update, filter) = updateAndFilter
+        |> mapToQueue { [weak self] (hideArchivedFolderByDefault, archiveFolderPresentation, displayArchiveIntro, storageInfo, savedMessagesPeer, updateAndFilter, state, contacts, chatListFilters, accountIsPremium) -> Signal<ChatListNodeListViewTransition, NoError> in
+            guard let strongSelf = self else {
+                return .complete()
+            }
+            let (update, filter, locationGeneration) = updateAndFilter
+            if locationGeneration != strongSelf.chatListLocationGeneration {
+                return .complete()
+            }
 
             let previousHideArchivedFolderByDefaultValue = previousHideArchivedFolderByDefault.swap(hideArchivedFolderByDefault)
             let previousArchiveFolderPresentationValue = previousArchiveFolderPresentation.swap(archiveFolderPresentation)
@@ -2689,9 +2701,11 @@ public final class ChatListNode: ListViewImpl {
                 searchMode = true
             }
 
+            var forceAllUpdated = false
             if filter != previousView?.filter {
                 disableAnimations = true
                 updatedScrollPosition = nil
+                forceAllUpdated = true
             }
 
             let filterData = filter.flatMap { filter -> ChatListItemFilterData? in
@@ -2702,7 +2716,6 @@ public final class ChatListNode: ListViewImpl {
                 }
             }
 
-            var forceAllUpdated = false
             let previousChatListFiltersValue = previousChatListFilters.swap(chatListFilters)
             if chatListFilters != previousChatListFiltersValue {
                 forceAllUpdated = true
@@ -2725,7 +2738,7 @@ public final class ChatListNode: ListViewImpl {
         }
 
         self.displayedItemRangeChanged = { [weak self] range, transactionOpaqueState in
-            if let strongSelf = self, let chatListView = (transactionOpaqueState as? ChatListOpaqueTransactionState)?.chatListView {
+            if let strongSelf = self, strongSelf.isActiveForFolderPagination, let chatListView = (transactionOpaqueState as? ChatListOpaqueTransactionState)?.chatListView {
                 let originalList = chatListView.originalList
                 if let range = range.loadedRange {
                     var location: ChatListNodeLocation?
@@ -3803,8 +3816,16 @@ public final class ChatListNode: ListViewImpl {
         }
     }
 
+    func reconcileLocationOnTabActivation() {
+        self.isActiveForFolderPagination = true
+        if case .navigation = self.currentLocation {
+            self.setChatListLocation(.initial(count: 50, filter: self.chatListFilter))
+        }
+    }
+    
     private func setChatListLocation(_ location: ChatListNodeLocation) {
         self.currentLocation = location
+        self.chatListLocationGeneration &+= 1
         self.chatListLocation.set(location)
     }