Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: beetbox/beets
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: beetbox/beets
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: introduce-album-import-task
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 44 files changed
  • 1 contributor

Commits on Jul 17, 2026

  1. Move AttrDict under beets.util

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    6e2ed46 View commit details
    Browse the repository at this point in the history

  2. Exclude AttrDict move from git blame

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    0ae5ce1 View commit details
    Browse the repository at this point in the history

  3. Refactor autotag to use Source abstraction 

    Introduce Source class to encapsulate metadata extraction logic,
replacing scattered `get_most_common_tags` calls throughout codebase.

- Add Source class in importer.tasks with artist, name, and metadata
- Simplify `distance()` to accept Source.data instead of items list
- Update display functions to use Source objects
- Cache Source creation with @cached_property on ImportTask

This centralizes metadata handling and reduces coupling between
autotag and library modules.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    4926607 View commit details
    Browse the repository at this point in the history

  4. Ignore Match move commit

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    8e6de67 View commit details
    Browse the repository at this point in the history

  5. Define a container for Likelies

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    300fae0 View commit details
    Browse the repository at this point in the history

  6. Move methods belonging to albums under AlbumChange

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    75f6c95 View commit details
    Browse the repository at this point in the history

  7. Rename ChangeRepresentation -> Change

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    ca771c7 View commit details
    Browse the repository at this point in the history

  8. Unify import match change display flow 

    - Route both album and track preview output through one show_change path
  with polymorphic Change helpers.
- Removes duplicate branching in session prompts and keeps preview
  rendering behavior centralized.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    bc3978c View commit details
    Browse the repository at this point in the history

  9. Delegate Match validation to Match subclasses

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    0b0bbe8 View commit details
    Browse the repository at this point in the history

  10. Refactor autotag matching around candidate collections 

    - Replace `tag_album`/`tag_item` proposal flows with `AlbumCandidates`
  and `TrackCandidates` that own candidate aggregation, ID/text search,
  sorting, and recommendation calculation.
- Update importer/session/plugin call sites to use
  `task.candidates.recommendation` and in-place candidate resolution,
  reducing duplicated control flow and centralizing match behavior.
- Adjust related tests and exports for the new API, normalize displayed
  match type casing, and mark the current `mbpseudo` dynamic adjustment
  behavior as expected-failing pending redesign.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    24b3706 View commit details
    Browse the repository at this point in the history

  11. Create a module for candidates

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    9b70845 View commit details
    Browse the repository at this point in the history

  12. Extract album-specific behavior into AlbumImportTask 

    - Move album-only methods from ImportTask into a new AlbumImportTask
  subclass and make ImportTask generic over the library model type.
- Export AnyLibModel from the library package and use it to tighten task
  and duplicate lookup typing.
- This separates album and singleton responsibilities, removes the
  previous override-ignore workaround, and clarifies task contracts for
  future importer refactors.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    65f9818 View commit details
    Browse the repository at this point in the history

  13. Refactor reimport metadata flow across import task types 

    - Extract shared flexible-attribute overwrite filtering into
  ImportTask._get_reimport_flexattrs.
- Move album-specific reimport preservation into AlbumImportTask and
  delegate shared item handling to super() to keep orchestration focused
  and reduce mixed type branching.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    2e3c2b9 View commit details
    Browse the repository at this point in the history

  14. Simplify is_album logic

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    78cfb86 View commit details
    Browse the repository at this point in the history

  15. Make ImportTask.cleanup own the import config

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    b4d6e5e View commit details
    Browse the repository at this point in the history

  16. Clean up archive imports during finalize 

    - Move shared progress finalization to BaseImportTask and introduce ProgressTask
  for non-importing progress markers.
- Run archive cleanup from ArchiveImportTask.finalize so completed move imports
  remove the archive while partial imports preserve it.
    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    f8021bb View commit details
    Browse the repository at this point in the history

  17. typing: add types to ui.commands.import_

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    84b61d9 View commit details
    Browse the repository at this point in the history

  18. Rename ImportSession.choose_match -> ImportSession.choose_album

    @snejus
    snejus committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    62cf563 View commit details
    Browse the repository at this point in the history
Loading