chore: Update formatting rules (#248)

* chore: Update formatting rules

* Remove extra noxfile and lint.yml

Author: holtskinner

.github/workflows/lint.yml

@@ -4,44 +4,31 @@
 #
 # This file follows the standards in Google Python Style Guide
 # https://google.github.io/styleguide/pyguide.html
-#  
-# The settings below are for the IDE configuration, and are optional.
-#{
-#    "editor.formatOnSave": true,
-#    "[python]": {
-#        "editor.defaultFormatter": "charliermarsh.ruff",
-#        "editor.formatOnSave": true,
-#        "editor.codeActionsOnSave": {
-#            "source.organizeImports": "true"
-#        },
-#    },    
-#    "ruff.importStrategy": "fromEnvironment",
-#}
+#
 
 line-length = 80 # Google Style Guide §3.2: 80 columns
 indent-width = 4 # Google Style Guide §3.4: 4 spaces
 
-target-version = "py312" # Minimum Python version
+target-version = "py310" # Minimum Python version
 
 [lint]
 ignore = [
-    "COM812",
-    "FBT001",
-    "FBT002",
-    "D203",
-    "D213",
-    "ANN001",
-    "ANN201",
-    "ANN204",
-    "D100", # Ignore Missing docstring in public module (often desired at top level __init__.py)
-    "D102", # Ignore return type annotation in public method
-    "D104", # Ignore Missing docstring in public package (often desired at top level __init__.py)
-    "D107", # Ignore Missing docstring in __init__ (use class docstring)
-    "TD002", # Ignore Missing author in TODOs (often not required)
-    "TD003", # Ignore Missing issue link in TODOs (often not required/available)
-    "T201", # Ignore print presence
+    "COM812", # Trailing comma missing.
+    "FBT001", # Boolean positional arg in function definition
+    "FBT002", # Boolean default value in function definition
+    "D203",   # 1 blank line required before class docstring (Google: 0)
+    "D213",   # Multi-line docstring summary should start at the second line (Google: first line)
+    "D100",   # Ignore Missing docstring in public module (often desired at top level __init__.py)
+    "D104",   # Ignore Missing docstring in public package (often desired at top level __init__.py)
+    "D107",   # Ignore Missing docstring in __init__ (use class docstring)
+    "TD002",  # Ignore Missing author in TODOs (often not required)
+    "TD003",  # Ignore Missing issue link in TODOs (often not required/available)
+    "T201",   # Ignore print presence
     "RUF012", # Ignore Mutable class attributes should be annotated with `typing.ClassVar`
-    "RUF013", # Ignore implicit optional
+    "E501",   # Ignore line length (handled by Ruff's dynamic line length)
+    "ANN002",
+    "ANN003",
+    "ANN401",
 ]
 
 select = [
@@ -62,12 +49,14 @@ select = [
     "PTH",# flake8-use-pathlib (use pathlib instead of os.path where possible)
     "PL", # Pylint rules ported to Ruff (PLC, PLE, PLR, PLW)
     "PIE",# flake8-pie (misc code improvements, e.g., no-unnecessary-pass)
-    "RUF",# Ruff-specific rules (e.g., RUF001-003 ambiguous unicode)
+    "RUF",# Ruff-specific rules (e.g., RUF001-003 ambiguous unicode, RUF013 implicit optional)
     "RET",# flake8-return (consistency in return statements)
     "SLF",# flake8-self (check for private member access via `self`)
     "TID",# flake8-tidy-imports (relative imports, banned imports - configure if needed)
     "YTT",# flake8-boolean-trap (checks for boolean positional arguments, truthiness tests - Google Style §3.10)
     "TD", # flake8-todos (check TODO format - Google Style §3.7)
+    "TCH",# flake8-type-checking (helps manage TYPE_CHECKING blocks and imports)
+    "PYI",# flake8-pyi (best practices for .pyi stub files, some rules are useful for .py too)
 ]
 
 exclude = [
@@ -109,6 +98,7 @@ lines-between-types = 1
 
 [lint.pydocstyle]
 convention = "google"
+ignore-decorators = ["typing.overload", "abc.abstractmethod"]
 
 [lint.flake8-annotations]
 mypy-init-return = true
@@ -127,7 +117,7 @@ docstring-quotes = "double"
 inline-quotes = "single"
 
 [lint.per-file-ignores]
-"__init__.py" = ["F401"]  # Ignore unused imports in __init__.py
+"__init__.py" = ["F401", "D", "ANN"]  # Ignore unused imports in __init__.py
 "*_test.py" = ["D", "ANN"]  # Ignore docstring and annotation issues in test files
 "test_*.py" = ["D", "ANN"]  # Ignore docstring and annotation issues in test files
 

.ruff.toml

@@ -0,0 +1,23 @@
+{
+  "python.testing.pytestArgs": [
+    "tests"
+  ],
+  "python.testing.unittestEnabled": false,
+  "python.testing.pytestEnabled": true,
+  "editor.formatOnSave": true,
+  "[python]": {
+    "editor.defaultFormatter": "charliermarsh.ruff",
+    "editor.formatOnSave": true,
+    "editor.codeActionsOnSave": {
+      "source.organizeImports": "always",
+      "source.fixAll.ruff": "explicit"
+    }
+  },
+  "ruff.importStrategy": "fromEnvironment",
+  "files.insertFinalNewline": true,
+  "files.trimFinalNewlines": false,
+  "files.trimTrailingWhitespace": false,
+  "editor.rulers": [
+    80
+  ]
+}

.vscode/settings.json

@@ -0,0 +1,38 @@
+#!/bin/bash
+set -e
+set -o pipefail
+
+# Sort Spelling Allowlist
+# The user did not provide this file, so we check for its existence.
+SPELLING_ALLOW_FILE=".github/actions/spelling/allow.txt"
+if [ -f "$SPELLING_ALLOW_FILE" ]; then
+    sort -u "$SPELLING_ALLOW_FILE" -o "$SPELLING_ALLOW_FILE"
+fi
+
+TARGET_BRANCH="origin/${GITHUB_BASE_REF:-main}"
+git fetch origin "${GITHUB_BASE_REF:-main}" --depth=1
+
+# Find merge base between HEAD and target branch
+MERGE_BASE=$(git merge-base HEAD "$TARGET_BRANCH")
+
+# Get python files changed in this PR, excluding grpc generated files
+CHANGED_FILES=$(git diff --name-only --diff-filter=ACMRTUXB "$MERGE_BASE" HEAD -- '*.py' ':!src/a2a/grpc/*')
+
+if [ -z "$CHANGED_FILES" ]; then
+    echo "No changed Python files to format."
+    exit 0
+fi
+
+echo "Formatting changed files:"
+echo "$CHANGED_FILES"
+
+# Formatters are already installed in the activated venv from the GHA step.
+# Use xargs to pass the file list to the formatters.
+run_formatter() {
+    echo "$CHANGED_FILES" | xargs -r "$@"
+}
+
+run_formatter pyupgrade --exit-zero-even-if-changed --py310-plus
+run_formatter autoflake -i -r --remove-all-unused-imports
+run_formatter ruff check --fix-only
+run_formatter ruff format