Take version name from manifest of installed APK

Author: vkryl

app/src/main/java/org/thunderdog/challegram/Log.java

@@ -638,7 +638,7 @@ protected void process (Message msg) {
               osArch,
 
               // Related to Application Build
-              BuildConfig.VERSION_NAME,
+              U.getVersionName(),
               BuildConfig.ORIGINAL_VERSION_CODE,
 
               // Related to Android version
@@ -690,7 +690,7 @@ public static String getDeviceInformationString () {
     return String.format(
       Locale.US,
       "App: %s\nSDK: %d (%s)\nManufacturer: %s\nModel: %s\nBrand: %s\nDisplay: %s\nProduct: %s\nFingerprint: %s\nScreen: %dx%d (%f)\n",
-      BuildConfig.VERSION_NAME,
+      U.getVersionName(),
 
       Build.VERSION.SDK_INT,
       SdkVersion.getPrettyName(),

app/src/main/java/org/thunderdog/challegram/U.java

@@ -2394,6 +2394,26 @@ public static String getUsefulMetadata (@Nullable Tdlib tdlib) {
     return metadata;
   }
 
+  // Version name of the manifest of the installed APK, read once. A build of all ABIs makes an APK
+  // for each, with its ABI in the version name of its manifest, while all of them share one
+  // BuildConfig with the version name of one of them
+  private static volatile String versionName;
+
+  public static String getVersionName () {
+    String versionName = U.versionName;
+    if (versionName == null) {
+      try {
+        versionName = AppContext.get().getPackageManager()
+          .getPackageInfo(BuildConfig.APPLICATION_ID, 0).versionName;
+      } catch (Throwable ignored) { }
+      if (StringUtils.isEmpty(versionName)) {
+        return BuildConfig.VERSION_NAME;
+      }
+      U.versionName = versionName;
+    }
+    return versionName;
+  }
+
   public static String getApkFingerprint (String algorithm) {
     return getApkFingerprint(algorithm, true);
   }

app/src/main/java/org/thunderdog/challegram/core/Lang.java

@@ -33,9 +33,9 @@
 import androidx.annotation.UiThread;
 
 import org.drinkless.tdlib.TdApi;
-import org.thunderdog.challegram.BuildConfig;
 import org.thunderdog.challegram.Log;
 import org.thunderdog.challegram.R;
+import org.thunderdog.challegram.U;
 import org.thunderdog.challegram.config.Config;
 import org.thunderdog.challegram.data.ContentPreview;
 import org.thunderdog.challegram.data.TD;
@@ -1049,7 +1049,7 @@ public static String getNotificationCategory (int category) {
   // Build no
 
   public static String getAppBuildAndVersion (@Nullable Tdlib tdlib) {
-    String msg = getString(R.string.AppNameAndVersion, BuildConfig.VERSION_NAME);
+    String msg = getString(R.string.AppNameAndVersion, U.getVersionName());
     if (tdlib != null && tdlib.isEmulator()) {
       msg += " (emulator)";
     }

app/src/main/java/org/thunderdog/challegram/data/TGMessage.java

@@ -55,7 +55,6 @@
 import org.drinkless.tdlib.TdApi;
 import org.drinkmore.Tracer;
 import org.thunderdog.challegram.BaseActivity;
-import org.thunderdog.challegram.BuildConfig;
 import org.thunderdog.challegram.Log;
 import org.thunderdog.challegram.R;
 import org.thunderdog.challegram.U;
@@ -8537,7 +8536,7 @@ public static TGMessage valueOfError (MessagesManager context, TdApi.Message msg
 
     logEntity.offset = b.length();
 
-    b.append(Lang.getString(R.string.AppName)).append(' ').append(BuildConfig.VERSION_NAME).append("\n");
+    b.append(Lang.getString(R.string.AppName)).append(' ').append(U.getVersionName()).append("\n");
     b.append("Type: ").append(msg.content != null ? msg.content.getClass().getSimpleName() : "NULL").append("\n");
     b.append("Android: ").append(SdkVersion.getPrettyName()).append(" (").append(Build.VERSION.SDK_INT).append(")\n");
     b.append("Screen: ").append(Screen.widestSide()).append("x").append(Screen.smallestSide()).append("x").append(Screen.density()).append("\n");

app/src/main/java/org/thunderdog/challegram/telegram/Tdlib.java

@@ -523,7 +523,7 @@ public TdlibCounter getCounter (@NonNull TdApi.ChatList chatList) {
         BuildConfig.TELEGRAM_API_ID,
         BuildConfig.TELEGRAM_API_HASH,
         null, null, null, // updateParameters
-        BuildConfig.VERSION_NAME
+        U.getVersionName()
       );
     } else {
       this.parameters = new TdApi.SetTdlibParameters(
@@ -536,7 +536,7 @@ public TdlibCounter getCounter (@NonNull TdApi.ChatList chatList) {
         BuildConfig.TELEGRAM_API_ID,
         BuildConfig.TELEGRAM_API_HASH,
         null, null, null, // updateParameters
-        BuildConfig.VERSION_NAME
+        U.getVersionName()
       );
     }
 
@@ -4730,7 +4730,7 @@ public boolean hasPotentiallyVisibleMessages () {
 
   public String emailMetadata () {
     return Lang.getString(R.string.email_metadata,
-      BuildConfig.VERSION_NAME,
+      U.getVersionName(),
       languagePackId,
       TdlibManager.getSystemLanguageCode(),
       TdlibManager.getSystemVersion());

app/src/main/java/org/thunderdog/challegram/ui/IntroController.java

@@ -326,7 +326,7 @@ private static boolean hasDefaultGlConfigImpl () {
         String text = Lang.getString(languagePackInfo,
           R.string.email_LoginTooLong_text,
 
-          BuildConfig.VERSION_NAME,
+          U.getVersionName(),
           languagePackInfo.id,
           Lang.getDuration((int) (getTdlib().timeSinceFirstConnectionAttemptMs() / 1000l)) + " (" + networkTypeStr + ")",
           TdlibManager.getSystemLanguageCode(),

app/src/main/java/org/thunderdog/challegram/ui/SettingsBugController.java

@@ -172,7 +172,7 @@ public CharSequence getName () {
     }
     switch (section) {
       case Section.MAIN:
-        return BuildConfig.VERSION_NAME;
+        return U.getVersionName();
       case Section.UTILITIES:
         return Lang.getString(R.string.TestMode);
       case Section.PUSH:

app/src/main/java/org/thunderdog/challegram/ui/SettingsController.java

@@ -1444,7 +1444,7 @@ private void showBuildOptions (boolean allowDebug) {
     }
 
     SpannableStringBuilder b = new SpannableStringBuilder();
-    b.append(Lang.getMarkdownStringSecure(this, R.string.AppSignature, BuildConfig.VERSION_NAME));
+    b.append(Lang.getMarkdownStringSecure(this, R.string.AppSignature, U.getVersionName()));
 
     showOptions(b, ids.get(), strings.get(), colors.get(), icons.get(), (itemView, id) -> {
       if (id == R.id.btn_copyText) {